i#7588 drsyscall: fix a boundary condition bug in drsyscall_iterate_records. #7736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
derekbruening
left a comment
derekbruening
left a comment
There was a problem hiding this comment.
Switch tests to all-in-one to avoid potential flakiness from magic constants?
clients/drcachesim/tests/offline-drsyscall-record-test.templatex
Outdated
Show resolved
Hide resolved
clients/drcachesim/tests/offline-drsyscall-record-test.templatex
Outdated
Show resolved
Hide resolved
clients/drcachesim/tests/offline-drsyscall-record-test.templatex
Outdated
Show resolved
Hide resolved
This was referenced Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in drsyscall_iterate_records() where it stops to process syscall record if a record ends exactly at the end of its buffer. This bug affects both drsyscall_record_trimmer and drsyscall_record_viewer.
The root cause of this failure is not in the syscall record collection but rather in the iteration logic used by drsyscall_iterate_records() during subsequent processing.
Add a unit test which has a syscall record which ends exactly at the end of the buffer. Without the fix, the syscall record DRSYS_RECORD_END_TIMESTAMP will not be read.
Issue: #7588