Skip to content

Commit ac592a9

Browse files
davidstosikE1337Kat
authored andcommitted
Remove dev dependency to Thin (zipmark#479)
This change is part of preliminary efforts at attempting to refresh the Continuous Integration setup, by supporting recent Ruby version and updating dependencies. To be honest, I don't know what benefits the Thin server brings to the table. I tried digging in the code, but the commit that introduced it does not tell me much: cdeea8b. What I know however is that I have troubles running the specs locally, getting a timeout on this line: https://github.com/zipmark/rspec_api_documentation/blob/560c3bdc7bd5581e7c223334390221ecfc910be8/spec/http_test_client_spec.rb#L16 However, letting Capybara handle its server details, as shown in this PR, does not seem to have any negative impact (spec is still green, and fairly fast).
1 parent 54f7d13 commit ac592a9

File tree

2 files changed

+0
-8
lines changed

2 files changed

+0
-8
lines changed

rspec_api_documentation.gemspec

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ Gem::Specification.new do |s|
2929
s.add_development_dependency "webmock", "~> 1.22.6"
3030
s.add_development_dependency "rspec-its", "~> 1.2.0"
3131
s.add_development_dependency "faraday", "~> 0.9.2"
32-
s.add_development_dependency "thin", "~> 1.6.4"
3332
s.add_development_dependency "nokogiri", "~> 1.8.4"
3433
s.add_development_dependency "yard", "~> 0.9.15"
3534
s.add_development_dependency "inch", "~> 0.8.0"

spec/http_test_client_spec.rb

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,6 @@
99
describe RspecApiDocumentation::HttpTestClient do
1010
before(:all) do
1111
WebMock.allow_net_connect!
12-
13-
Capybara.server do |app, port|
14-
require 'rack/handler/thin'
15-
Thin::Logging.silent = true
16-
Rack::Handler::Thin.run(app, :Port => port)
17-
end
18-
1912
server = Capybara::Server.new(StubApp.new, 8888)
2013
server.boot
2114
end

0 commit comments

Comments
 (0)