Skip to content

Commit f691104

Browse files
authored
chore(deps): update reviewdog to 0.21.0 and fix: add -fail-level and deprecate -fail-on-error (#75)
* chore(deps): update reviewdog to 0.21.0 * fix: add -fail-level and deprecate -fail-on-error
1 parent ea9650f commit f691104

File tree

3 files changed

+21
-1
lines changed

3 files changed

+21
-1
lines changed

README.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,10 +72,18 @@ inputs:
7272
Default is `added`.
7373
default: 'added'
7474
required: false
75+
fail_level:
76+
description: |
77+
If set to `none`, always use exit code 0 for reviewdog. Otherwise, exit code 1 for reviewdog if it finds at least 1 issue with severity greater than or equal to the given level.
78+
Possible values: [none,any,info,warning,error]
79+
Default is `none`.
80+
default: 'none'
7581
fail_on_error:
7682
description: |
83+
Deprecated, use `fail_level` instead.
7784
Exit code for reviewdog when errors are found [true,false].
7885
Default is `false`.
86+
deprecationMessage: Deprecated, use `fail_level` instead.
7987
default: 'false'
8088
required: false
8189
reviewdog_flags:

action.yml

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,10 +35,18 @@ inputs:
3535
Default is `added`.
3636
default: 'added'
3737
required: false
38+
fail_level:
39+
description: |
40+
If set to `none`, always use exit code 0 for reviewdog. Otherwise, exit code 1 for reviewdog if it finds at least 1 issue with severity greater than or equal to the given level.
41+
Possible values: [none,any,info,warning,error]
42+
Default is `none`.
43+
default: 'none'
3844
fail_on_error:
3945
description: |
46+
Deprecated, use `fail_level` instead.
4047
Exit code for reviewdog when errors are found [true,false].
4148
Default is `false`.
49+
deprecationMessage: Deprecated, use `fail_level` instead.
4250
default: 'false'
4351
required: false
4452
reviewdog_flags:
@@ -66,7 +74,7 @@ runs:
6674
steps:
6775
- uses: reviewdog/action-setup@v1
6876
with:
69-
reviewdog_version: v0.14.2
77+
reviewdog_version: v0.21.0
7078
- run: $GITHUB_ACTION_PATH/script.sh
7179
shell: bash
7280
env:
@@ -75,6 +83,7 @@ runs:
7583
INPUT_LEVEL: ${{ inputs.level }}
7684
INPUT_REPORTER: ${{ inputs.reporter }}
7785
INPUT_FILTER_MODE: ${{ inputs.filter_mode }}
86+
INPUT_FAIL_LEVEL: ${{ inputs.fail_level }}
7887
INPUT_FAIL_ON_ERROR: ${{ inputs.fail_on_error }}
7988
INPUT_REVIEWDOG_FLAGS: ${{ inputs.reviewdog_flags }}
8089
INPUT_TOOL_NAME: ${{ inputs.tool_name }}
@@ -86,6 +95,7 @@ runs:
8695
tool_name: ${{ inputs.tool_name }}
8796
level: ${{ inputs.level }}
8897
filter_mode: ${{ inputs.filter_mode }}
98+
fail_level: ${{ inputs.fail_level }}
8999
fail_on_error: ${{ inputs.fail_on_error }}
90100
reviewdog_flags: ${{ inputs.reviewdog_flags }}
91101

script.sh

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ if [ "$INPUT_REPORTER" = "github-pr-review" ]; then
3333
-name="${INPUT_TOOL_NAME}" \
3434
-reporter="${INPUT_REPORTER}" \
3535
-filter-mode="${INPUT_FILTER_MODE}" \
36+
-fail-level=${INPUT_FAIL_LEVEL} \
3637
-fail-on-error="${INPUT_FAIL_ON_ERROR}" \
3738
-level="${INPUT_LEVEL}" \
3839
"${INPUT_REVIEWDOG_FLAGS}"
@@ -51,6 +52,7 @@ else
5152
-name="${INPUT_TOOL_NAME}" \
5253
-reporter="${INPUT_REPORTER}" \
5354
-filter-mode="${INPUT_FILTER_MODE}" \
55+
-fail-level=${INPUT_FAIL_LEVEL} \
5456
-fail-on-error="${INPUT_FAIL_ON_ERROR}" \
5557
-level="${INPUT_LEVEL}" \
5658
"${INPUT_REVIEWDOG_FLAGS}"

0 commit comments

Comments
 (0)