-
Notifications
You must be signed in to change notification settings - Fork 261
Jupyter extension: Pre-release set to latest version #569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
See eclipse/openvsx#436 for previous discussion. |
Hi @benz0li 👋! So, about the two extensions (and probably many more): we don't do pre-releases here in the repo, yet. I think it is an interesting idea to explore in the near future, but for now we always publish the latest stable version of extensions and the introduction of double publishing / one for each channel - stable and prerelease would add a quite large amount of complexity, which probably means it would not work a lot of the time. Still a thing worth considering. Thanks for bringing it to our attention. |
Thanks for your prompt reply. I'm not asking about publishing pre-releases. https://open-vsx.org/extension/ms-toolsai/jupyter/2022.3.1000752054 is not the latest stable version but a pre-release. |
@filiptronicek I'm wondering why version |
Oh, sorry for the misunderstanding, I see what you mean. This is a problem with the publishing script, which published it on the 14th of March, because it couldn't change to a release tag, so it started guessing. It took the first commit around the time of the Microsoft release looking for whatever it could find, after that, it just published what it could, this being the I will try to patch this behavior, but it is a bit trickier with these extensions where semver is not used. Thanks for reporting this, I am currently investigating it. |
This is going to be tricky to solve, since as @benz0li stated, We could somehow leverage the fact that Jupyter publishes a built extension package on every commit [1], but that would require us to:
|
For the time being, I will simply pin the version of this extension. @filiptronicek Thanks for your detailed feedback. Versioning and publishing on Microsoft's side is utterly obscure. |
Your current mechanism for publishing releases of I'm going to pin the versions for |
https://open-vsx.org/extension/ms-toolsai/jupyter/2022.3.1000752054 should not have been published as https://open-vsx.org/extension/ms-toolsai/jupyter/latest [for now at least].
In comparison:
ESLint
https://open-vsx.org/extension/dbaeumer/vscode-eslint/latest is https://open-vsx.org/extension/dbaeumer/vscode-eslint/2.2.2.
👉 v2.2.3 (pre-release) has been out since mid January but is not published on Open VSX.
Python
https://open-vsx.org/extension/ms-python/python/latest is https://open-vsx.org/extension/ms-python/python/2022.2.1924087327
👉 2022.3.n{10} (pre-release) has been out for some time but is not published on Open VSX.
@filiptronicek In my opinion publishing of ESLint and Python extension is handled correctly, but not for Jupyter extension.
Does 9fe3cf4 work correctly for ms-toolsai.jupyter?
The text was updated successfully, but these errors were encountered: