Skip to content

Conversation

@Erisa
Copy link
Owner

@Erisa Erisa commented May 8, 2025

No description provided.

@Erisa Erisa requested a review from Copilot May 8, 2025 23:24
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request refactors the build process to utilize the new bake configuration and action.

  • Introduces a new docker-bake.hcl file with configurable build targets and parameters.
  • Updates the Dockerfile to remove defaults for certain build arguments, relying on externally provided values.
  • Modifies the GitHub Actions workflow to switch to docker/bake-action and adjust triggering and pushing behavior.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
docker-bake.hcl Adds a new bake configuration file with build variables and targets.
Dockerfile Removes default values for GOVERSION, ALPINEVERSION, and VERSION.
.github/workflows/docker-build.yml Switches to using docker/bake-action and changes push behavior.
Comments suppressed due to low confidence (3)

Dockerfile:3

  • Removing the default for ALPINEVERSION might cause build failures if the argument is not provided externally. Consider adding a default or ensuring the build system supplies it.
ARG ALPINEVERSION

Dockerfile:14

  • The removal of a default value for VERSION may lead to build issues if this argument is not set during build time. Verify that the value is reliably provided by the external build configuration.
ARG VERSION

.github/workflows/docker-build.yml:38

  • Setting 'push: false' means the built images are not pushed. Confirm that this behavior is intended for your CI/CD workflow.
push: false

@Erisa Erisa force-pushed the erisa/baked-goods branch 6 times, most recently from f02d83a to 24c7397 Compare May 8, 2025 23:44
@Erisa Erisa force-pushed the erisa/baked-goods branch from 24c7397 to fac43dc Compare May 8, 2025 23:45
@Erisa Erisa merged commit 348a4c4 into main May 8, 2025
3 checks passed
@Erisa Erisa deleted the erisa/baked-goods branch May 9, 2025 00:37
Erisa added a commit that referenced this pull request May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant