Skip to content

buildFederatedSchema ignores custom directives #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
padenj opened this issue Jan 29, 2020 · 2 comments
Closed

buildFederatedSchema ignores custom directives #39

padenj opened this issue Jan 29, 2020 · 2 comments

Comments

@padenj
Copy link

padenj commented Jan 29, 2020

Apollo's buildFederatedSchema only adds built-in directives to the schema. It does not honor the schemaDirectives option. Therefore, any custom directives are ignored. See issue apollographql/apollo-feature-requests#145.

A workaround could be to use mergeSchemas to add in the schema definition after building the federated schema.

@tlivings
Copy link
Collaborator

tlivings commented Feb 5, 2020

Fixed in #40

@tlivings tlivings closed this as completed Feb 5, 2020
@padenj
Copy link
Author

padenj commented Feb 10, 2020

The fix for this issue causes extended properties to be ignored when publishing a schema to Apollo GraphManager. PR #41 is a less intrusive way to add custom directives with less side effects on the federated schema.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants