Skip to content

Commit 33df5e6

Browse files
authored
No longer specify remap in any Mixins (#4833)
This is only used by the anntation processor,
1 parent 974c632 commit 33df5e6

File tree

24 files changed

+29
-31
lines changed

24 files changed

+29
-31
lines changed

fabric-client-gametest-api-v1/src/client/java/net/fabricmc/fabric/mixin/client/gametest/threading/MainMixin.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424

2525
@Mixin(Main.class)
2626
public class MainMixin {
27-
@WrapWithCondition(method = "main", remap = false, at = @At(value = "INVOKE", target = "Lnet/minecraft/util/Util;startTimerHack()V", remap = true))
27+
@WrapWithCondition(method = "main", at = @At(value = "INVOKE", target = "Lnet/minecraft/util/Util;startTimerHack()V"))
2828
private static boolean dontStartAnotherTimerHack() {
2929
return false;
3030
}

fabric-client-gametest-api-v1/src/client/java/net/fabricmc/fabric/mixin/client/gametest/threading/ThreadExecutorMixin.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ private void onPacketHandlerSchedule(Runnable task, CallbackInfo ci) {
3939
}
4040
}
4141

42-
@Inject(method = "executeTask", at = @At(value = "INVOKE", target = "Ljava/lang/Runnable;run()V", remap = false, shift = At.Shift.AFTER))
42+
@Inject(method = "executeTask", at = @At(value = "INVOKE", target = "Ljava/lang/Runnable;run()V", shift = At.Shift.AFTER))
4343
private void onPacketHandlerRun(Runnable task, CallbackInfo ci) {
4444
switch ((Object) this) {
4545
case MinecraftClient $ -> NetworkSynchronizer.CLIENTBOUND.postTaskRun(task);

fabric-command-api-v2/src/main/java/net/fabricmc/fabric/mixin/command/CommandManagerMixin.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ public abstract class CommandManagerMixin {
4343
*
4444
* @reason Add commands before ambiguities are calculated.
4545
*/
46-
@Inject(at = @At(value = "INVOKE", target = "Lcom/mojang/brigadier/CommandDispatcher;setConsumer(Lcom/mojang/brigadier/ResultConsumer;)V", remap = false), method = "<init>")
46+
@Inject(at = @At(value = "INVOKE", target = "Lcom/mojang/brigadier/CommandDispatcher;setConsumer(Lcom/mojang/brigadier/ResultConsumer;)V"), method = "<init>")
4747
private void fabric_addCommands(CommandManager.RegistrationEnvironment environment, CommandRegistryAccess registryAccess, CallbackInfo ci) {
4848
CommandRegistrationCallback.EVENT.invoker().register(this.dispatcher, registryAccess, environment);
4949
}

fabric-crash-report-info-v1/src/main/java/net/fabricmc/fabric/mixin/crash/report/info/DedicatedServerWatchdogMixin.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,7 @@ public class DedicatedServerWatchdogMixin {
3131
@ModifyArg(method = "createCrashReport(Ljava/lang/String;J)Lnet/minecraft/util/crash/CrashReport;",
3232
at = @At(value = "INVOKE",
3333
target = "Ljava/lang/StringBuilder;append(Ljava/lang/Object;)Ljava/lang/StringBuilder;",
34-
ordinal = 0,
35-
remap = false)
34+
ordinal = 0)
3635
)
3736
private static Object printEntireThreadDump(Object object) {
3837
if (object instanceof ThreadInfo threadInfo) {

fabric-data-generation-api-v1/src/client/java/net/fabricmc/fabric/mixin/datagen/client/MinecraftClientMixin.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727

2828
@Mixin(MinecraftClient.class)
2929
public class MinecraftClientMixin {
30-
@Inject(method = "<init>", at = @At(value = "INVOKE", target = "Lcom/mojang/blaze3d/systems/RenderSystem;getBackendDescription()Ljava/lang/String;", remap = false))
30+
@Inject(method = "<init>", at = @At(value = "INVOKE", target = "Lcom/mojang/blaze3d/systems/RenderSystem;getBackendDescription()Ljava/lang/String;"))
3131
private void main(CallbackInfo info) {
3232
if (FabricDataGenHelper.ENABLED) {
3333
FabricDataGenHelper.run();

fabric-data-generation-api-v1/src/client/java/net/fabricmc/fabric/mixin/datagen/client/ModelProviderBlockStateSuppliersMixin.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ public void setFabricDataOutput(FabricDataOutput fabricDataOutput) {
4141
}
4242

4343
// Target the first .filter() call, to filter out blocks that are not from the mod we are processing.
44-
@ModifyArg(method = "validate", at = @At(value = "INVOKE", target = "Ljava/util/stream/Stream;filter(Ljava/util/function/Predicate;)Ljava/util/stream/Stream;", ordinal = 0, remap = false))
44+
@ModifyArg(method = "validate", at = @At(value = "INVOKE", target = "Ljava/util/stream/Stream;filter(Ljava/util/function/Predicate;)Ljava/util/stream/Stream;", ordinal = 0))
4545
private Predicate<RegistryEntry.Reference<Block>> filterBlocksForProcessingMod(Predicate<RegistryEntry.Reference<Block>> original) {
4646
if (fabricDataOutput != null) {
4747
return original

fabric-data-generation-api-v1/src/client/java/net/fabricmc/fabric/mixin/datagen/client/ModelProviderItemAssetsMixin.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ public void setFabricDataOutput(FabricDataOutput fabricDataOutput) {
5555
this.fabricDataOutput = fabricDataOutput;
5656
}
5757

58-
@WrapOperation(method = "method_65470", at = @At(value = "INVOKE", target = "Ljava/util/Map;containsKey(Ljava/lang/Object;)Z", ordinal = 1, remap = false))
58+
@WrapOperation(method = "method_65470", at = @At(value = "INVOKE", target = "Ljava/util/Map;containsKey(Ljava/lang/Object;)Z", ordinal = 1))
5959
private boolean filterItemsForProcessingMod(Map<Item, ItemAsset> map, Object o, Operation<Boolean> original) {
6060
BlockItem blockItem = (BlockItem) o;
6161

@@ -74,7 +74,7 @@ private boolean filterItemsForProcessingMod(Map<Item, ItemAsset> map, Object o,
7474
return original.call(map, o);
7575
}
7676

77-
@ModifyArg(method = "resolveAndValidate", at = @At(value = "INVOKE", target = "Ljava/util/stream/Stream;filter(Ljava/util/function/Predicate;)Ljava/util/stream/Stream;", ordinal = 0, remap = false))
77+
@ModifyArg(method = "resolveAndValidate", at = @At(value = "INVOKE", target = "Ljava/util/stream/Stream;filter(Ljava/util/function/Predicate;)Ljava/util/stream/Stream;", ordinal = 0))
7878
private Predicate<RegistryEntry.Reference<Item>> filterItemsForProcessingMod(Predicate<RegistryEntry.Reference<Item>> original) {
7979
if (fabricDataOutput != null) {
8080
return original

fabric-dimensions-v1/src/main/java/net/fabricmc/fabric/mixin/dimension/Schema2832Mixin.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,7 @@ public class Schema2832Mixin {
4242
},
4343
at = @At(
4444
value = "INVOKE",
45-
target = "Lcom/mojang/datafixers/DSL;taggedChoiceLazy(Ljava/lang/String;Lcom/mojang/datafixers/types/Type;Ljava/util/Map;)Lcom/mojang/datafixers/types/templates/TaggedChoice;",
46-
remap = false
45+
target = "Lcom/mojang/datafixers/DSL;taggedChoiceLazy(Ljava/lang/String;Lcom/mojang/datafixers/types/Type;Ljava/util/Map;)Lcom/mojang/datafixers/types/templates/TaggedChoice;"
4746
)
4847
)
4948
private static <K> TaggedChoice<K> redirectTaggedChoiceLazy(

fabric-dimensions-v1/src/main/java/net/fabricmc/fabric/mixin/dimension/TaggedChoiceMixin.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
import net.fabricmc.fabric.impl.dimension.TaggedChoiceExtension;
2929
import net.fabricmc.fabric.impl.dimension.TaggedChoiceTypeExtension;
3030

31-
@Mixin(value = TaggedChoice.class, remap = false)
31+
@Mixin(value = TaggedChoice.class)
3232
public class TaggedChoiceMixin implements TaggedChoiceExtension {
3333
@Unique
3434
boolean failSoft = false;
@@ -43,7 +43,7 @@ public class TaggedChoiceMixin implements TaggedChoiceExtension {
4343
*/
4444
@SuppressWarnings("rawtypes")
4545
@Inject(
46-
method = "lambda$apply$0", at = @At("RETURN"), remap = false
46+
method = "lambda$apply$0", at = @At("RETURN")
4747
)
4848
private void onApply(Pair key, CallbackInfoReturnable<Type> cir) {
4949
if (failSoft) {

fabric-dimensions-v1/src/main/java/net/fabricmc/fabric/mixin/dimension/TaggedChoiceTaggedChoiceTypeMixin.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,12 +33,12 @@
3333

3434
import net.fabricmc.fabric.impl.dimension.TaggedChoiceTypeExtension;
3535

36-
@Mixin(value = TaggedChoice.TaggedChoiceType.class, remap = false)
36+
@Mixin(value = TaggedChoice.TaggedChoiceType.class)
3737
public class TaggedChoiceTaggedChoiceTypeMixin<K> implements TaggedChoiceTypeExtension {
3838
@Unique
3939
private static final Logger LOGGER = LoggerFactory.getLogger("TaggedChoiceType_DimDataFix");
4040

41-
@Shadow(remap = false)
41+
@Shadow
4242
@Final
4343
protected Object2ObjectMap<K, Type<?>> types;
4444

@@ -51,7 +51,7 @@ public class TaggedChoiceTaggedChoiceTypeMixin<K> implements TaggedChoiceTypeExt
5151
* This will avoid deserialization failure from DFU when upgrading level.dat that contains mod custom generator types.
5252
*/
5353
@Inject(
54-
method = "getMapCodec", at = @At("HEAD"), cancellable = true, remap = false
54+
method = "getMapCodec", at = @At("HEAD"), cancellable = true
5555
)
5656
private void onGetCodec(K k, CallbackInfoReturnable<DataResult<? extends Codec<?>>> cir) {
5757
if (failSoft) {

0 commit comments

Comments
 (0)