Skip to content

Commit dfad440

Browse files
committed
[JavaScript] Simplify indentation rules
By utilizing the improved selector scoring of build 4173, we can simply have the two rules override each other based on the last meta scope on the stack.
1 parent a644c0e commit dfad440

File tree

2 files changed

+22
-20
lines changed

2 files changed

+22
-20
lines changed

JavaScript/Indentation Rules - Values.tmPreferences

Lines changed: 7 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -3,18 +3,10 @@
33
<dict>
44
<key>scope</key>
55
<string>
6-
(source.js meta.mapping, source.js meta.sequence) - source.js meta.function,
7-
source.js meta.function meta.mapping,
8-
source.js meta.function meta.sequence,
9-
(source.jsx meta.mapping, source.jsx meta.sequence) - source.jsx meta.function,
10-
source.jsx meta.function meta.mapping,
11-
source.jsx meta.function meta.sequence,
12-
(source.ts meta.mapping, source.ts meta.sequence) - source.ts meta.function,
13-
source.ts meta.function meta.mapping,
14-
source.ts meta.function meta.sequence,
15-
(source.tsx meta.mapping, source.tsx meta.sequence) - source.tsx meta.function,
16-
source.tsx meta.function meta.mapping,
17-
source.tsx meta.function meta.sequence
6+
source.js meta.mapping, source.js meta.sequence,
7+
source.jsx meta.mapping, source.jsx meta.sequence,
8+
source.ts meta.mapping, source.ts meta.sequence,
9+
source.tsx meta.mapping, source.tsx meta.sequence
1810
</string>
1911
<key>settings</key>
2012
<dict>
@@ -72,6 +64,9 @@
7264
($|/[/*])
7365
)
7466
</string>
67+
<!-- Reset for value rules -->
68+
<key>bracketIndentNextLinePattern</key>
69+
<string></string>
7570
</dict>
7671
</dict>
7772
</plist>

JavaScript/Indentation Rules.tmPreferences

Lines changed: 15 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,23 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<plist version="1.0">
33
<dict>
4+
<!--
5+
The meta.function scopes are used
6+
to re-override the separate mapping and sequence-sepcific patterns
7+
defined in `Indentation Rules - Values.tmPreferences`.
8+
This relies on a scope selector scoring adjustment in 4173.
9+
See also: https://github.com/sublimehq/sublime_text/issues/2152
10+
-->
411
<key>scope</key>
512
<string>
6-
source.js - source.js meta.mapping - source.js meta.sequence - source.js meta.string,
7-
source.js meta.function,
8-
source.jsx - source.jsx meta.mapping - source.jsx meta.sequence - source.jsx meta.string,
9-
source.jsx meta.function,
10-
source.ts - source.ts meta.mapping - source.ts meta.sequence - source.ts meta.string,
11-
source.ts meta.function,
12-
source.tsx - source.tsx meta.mapping - source.tsx meta.sequence - source.tsx meta.string,
13-
source.tsx meta.function
13+
source.js - source.js meta.string,
14+
source.js meta.function - source.js meta.string,
15+
source.jsx - source.jsx meta.string,
16+
source.jsx meta.function - source.jsx meta.string,
17+
source.ts - source.ts meta.string,
18+
source.ts meta.function - source.ts meta.string,
19+
source.tsx - source.tsx meta.string,
20+
source.tsx meta.function - source.tsx meta.string
1421
</string>
1522
<key>settings</key>
1623
<dict>

0 commit comments

Comments
 (0)