fix(components): fixes automatic uncovering of cells #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dev-in-disguise
added
bug
Flash0ver
reviewed
Mar 18, 2021
source/production/F0.Minesweeper.App/Properties/launchSettings.json
Outdated
Show resolved
Hide resolved
source/production/F0.Minesweeper.Components/Logic/Cell/DefaultCellStatusManager.cs
Show resolved
Hide resolved
|
|
||
| var uncoverableCells = | ||
| ( | ||
| from cell in cells |
There was a problem hiding this comment.
ooh la la ... I haven't seen LINQ in quite some time 😉 - I like it
There was a problem hiding this comment.
Me too. Was quite a pleasure using these rusty skills once again 😄
tabs are not only good for dishwashers
|
Hi Manuel
My preferred solution for such scenarios is a small factory interface, that
can be injected and has a Create method
It serves both purposes without modifications to the code base
For testing purpose, we just inject the "testable" factory
It may lead to a few lines of code more than the ctor overload
KR
|
|
Even if we don't inject the factory, the important part is that being an
interface, the Create method of the factory can be mocked easily in a test.
;)
|
Flash0ver
approved these changes
Apr 1, 2021
thomas-pemsel
approved these changes
Apr 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cells which are uncovered automatically due to the 0 adjacent mines feature are now re-rendered correctly.
Cells in the status covered and flagger which are tried to be uncovered automatically due to the 0 adjacent mines feature are no longer tried to be uncovered in the ui.
fixes #49 , fixes #51