Skip to content

Commit ee73086

Browse files
authored
Bug: (#338)
- Bug: Allow socket message to be null. Fixes #335, fixes #336.
1 parent 1c958c4 commit ee73086

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

CHANGELOG.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,10 @@
11
# Changelog
22

33
This project adheres to [Semantic Versioning](http://semver.org/).
4-
Every release, along with the migration instructions, is documented on the Github [Releases](https://github.com/FormidableLabs/webpack-dashboard/releases) page.
4+
5+
## UNRELEASED
6+
7+
- Bug: Allow socket messages to be null. [#335](https://github.com/FormidableLabs/webpack-dashboard/issues/335), [#336](https://github.com/FormidableLabs/webpack-dashboard/issues/336)
58

69
## [3.3.5] - 2021-07-12
710

bin/webpack-dashboard.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,9 @@ const main = opts => {
7676
});
7777

7878
socket.on("message", (message, ack) => {
79-
if (message.type !== "log") {
79+
// Note: `message` may be null.
80+
// https://github.com/FormidableLabs/webpack-dashboard/issues/335
81+
if (message && message.type !== "log") {
8082
dashboard.setData(message, ack);
8183
}
8284
});

0 commit comments

Comments
 (0)