Skip to content

Commit df0cab6

Browse files
committed
Merge pull request #957 from scribblet/master
Modify user variables to be nullable when expecting a DateTime
2 parents 1a6ca83 + 7f282ae commit df0cab6

File tree

4 files changed

+7
-5
lines changed

4 files changed

+7
-5
lines changed

Changelog.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@ Changelog
66
* Removed the deprecated UserManager and GroupManager classes for the different Doctrine implementations
77
* [BC break] Refactored the structure of controller to dispatch events instead of using form handlers
88
* Removed all form handlers
9+
* [BC break] Changed Datetime properties of default User entity that were nullable to default to null when no value supplied
10+
* [BC break] Updated schema.xml for Propel BaseUser class to allow nullable and typehint accordingly
911

1012
### 1.3.1 (2012-12-22)
1113

Model/User.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -392,7 +392,7 @@ public function setUsernameCanonical($usernameCanonical)
392392
*
393393
* @return User
394394
*/
395-
public function setCredentialsExpireAt(\DateTime $date)
395+
public function setCredentialsExpireAt(\DateTime $date = null)
396396
{
397397
$this->credentialsExpireAt = $date;
398398

@@ -451,7 +451,7 @@ public function setExpired($boolean)
451451
*
452452
* @return User
453453
*/
454-
public function setExpiresAt(\DateTime $date)
454+
public function setExpiresAt(\DateTime $date = null)
455455
{
456456
$this->expiresAt = $date;
457457

@@ -483,7 +483,7 @@ public function setPlainPassword($password)
483483
return $this;
484484
}
485485

486-
public function setLastLogin(\DateTime $time)
486+
public function setLastLogin(\DateTime $time = null)
487487
{
488488
$this->lastLogin = $time;
489489

Model/UserInterface.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,7 @@ public function isPasswordRequestNonExpired($ttl);
188188
*
189189
* @return self
190190
*/
191-
public function setLastLogin(\DateTime $time);
191+
public function setLastLogin(\DateTime $time = null);
192192

193193
/**
194194
* Never use this to check if this user has access to anything!

Resources/config/propel/schema.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
<parameter name="roles" value="array" />
3535
<parameter name="fos_group" value="FOS\UserBundle\Model\GroupInterface" />
3636

37-
<parameter name="nullable_columns" value="password_requested_at" />
37+
<parameter name="nullable_columns" value="password_requested_at, expires_at, last_login, credentials_expire_at" />
3838
</behavior>
3939
</table>
4040

0 commit comments

Comments
 (0)