Skip to content

[ENHANCEMENT] [MODDING] Scripted Class support for Sparrow Results Objects #5168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2025
Merged

[ENHANCEMENT] [MODDING] Scripted Class support for Sparrow Results Objects #5168

merged 1 commit into from
Jul 7, 2025

Conversation

KoloInDaCrib
Copy link
Contributor

Currently, only animatealtas objects for the ResultState have the priviledge of having a script class support. This PR gives sparrow objects the love they deserve, even if they aren't used that much :]

@github-actions github-actions bot added size: medium A medium pull request with 100 or fewer changes. pr: haxe PR modifies game code. status: pending triage Awaiting review. and removed size: medium A medium pull request with 100 or fewer changes. labels May 28, 2025
@AbnormalPoof AbnormalPoof added type: enhancement Involves an enhancement or new feature. topic: mods Related to the creation or use of mods. size: medium A medium pull request with 100 or fewer changes. labels May 28, 2025
TechnikTil
TechnikTil reviewed Jun 4, 2025
View reviewed changes
@AbnormalPoof AbnormalPoof added status: reviewing internally Under consideration and testing. and removed status: pending triage Awaiting review. labels Jun 20, 2025
@AbnormalPoof AbnormalPoof added status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. and removed status: reviewing internally Under consideration and testing. labels Jul 7, 2025
@AbnormalPoof AbnormalPoof added this to the 0.7.0 - Mobile Port milestone Jul 7, 2025
AbnormalPoof
AbnormalPoof approved these changes Jul 7, 2025
View reviewed changes
Copy link
Member

@AbnormalPoof AbnormalPoof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is GROOVY and not GLOOBY

@AbnormalPoof AbnormalPoof merged commit 719d115 into FunkinCrew:develop Jul 7, 2025
10 checks passed
@KoloInDaCrib KoloInDaCrib deleted the they-cant-keep-ignoring-these-forever branch July 7, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TechnikTil TechnikTil TechnikTil left review comments

@AbnormalPoof AbnormalPoof AbnormalPoof approved these changes

Assignees
No one assigned
Labels
pr: haxe PR modifies game code. size: medium A medium pull request with 100 or fewer changes. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. topic: mods Related to the creation or use of mods. type: enhancement Involves an enhancement or new feature.
Projects
None yet
Milestone
0.7.0 - Mobile Port
Development

Successfully merging this pull request may close these issues.
3 participants
@KoloInDaCrib @AbnormalPoof @TechnikTil