Skip to content

Commit 15b6365

Browse files
aslonnieFuture-Outlier
authored andcommitted
[core] build dashboard with wanda (ray-project#56886)
- will have caching enabled as a result - also builds in parallel with ray core binary bits - free to use a different build env image and upgrade npm now!! (if all places on CI uses this) Signed-off-by: Lonnie Liu <lonnie@anyscale.com> Signed-off-by: Future-Outlier <eric901201@gmail.com>
1 parent 8587b41 commit 15b6365

File tree

5 files changed

+45
-7
lines changed

5 files changed

+45
-7
lines changed

.buildkite/build.rayci.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,11 @@ steps:
1414
ARCH_SUFFIX: ""
1515
depends_on: manylinux
1616

17+
- name: wanda_ray_dashboard
18+
label: "wanda: dashboard"
19+
wanda: ci/docker/ray-dashboard.wanda.yaml
20+
depends_on: manylinux
21+
1722
- label: ":tapioca: build: wheel {{matrix}} (x86_64)"
1823
key: linux_wheels
1924
tags:

ci/docker/ray-core.Dockerfile

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,10 @@
11
# syntax=docker/dockerfile:1.3-labs
2-
FROM cr.ray.io/rayproject/manylinux as builder
2+
FROM cr.ray.io/rayproject/manylinux AS builder
33

44
ARG PYTHON_VERSION=3.9
55
ARG BUILDKITE_BAZEL_CACHE_URL
66
ARG BUILDKITE_CACHE_READONLY
77

8-
RUN mkdir /home/forge/ray
9-
108
WORKDIR /home/forge/ray
119

1210
COPY . .
@@ -30,10 +28,10 @@ fi
3028

3129
bazelisk build --config=ci //:ray_pkg_zip
3230

33-
cp bazel-bin/ray_pkg.zip /ray_pkg.zip
31+
cp bazel-bin/ray_pkg.zip /home/forge/ray_pkg.zip
3432

3533
EOF
3634

3735
FROM scratch
3836

39-
COPY --from=builder /ray_pkg.zip /ray_pkg.zip
37+
COPY --from=builder /home/forge/ray_pkg.zip /ray_pkg.zip

ci/docker/ray-core.wanda.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
1-
name: "ray_core_py$PYTHON_VERSION$ARCH_SUFFIX"
1+
name: "ray-core-py$PYTHON_VERSION$ARCH_SUFFIX"
22
froms: ["cr.ray.io/rayproject/manylinux"]
3+
dockerfile: ci/docker/ray-core.Dockerfile
34
srcs:
45
- .bazelversion
56
- .bazelrc
@@ -24,4 +25,3 @@ build_args:
2425
- BUILDKITE_BAZEL_CACHE_URL
2526
build_hint_args:
2627
- BUILDKITE_CACHE_READONLY
27-
dockerfile: ci/docker/ray-core.Dockerfile

ci/docker/ray-dashboard.Dockerfile

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
FROM cr.ray.io/rayproject/manylinux AS builder
2+
3+
WORKDIR /home/forge/ray
4+
5+
COPY --chown=forge:users . .
6+
7+
RUN <<EOF
8+
#!/bin/bash
9+
10+
set -euo pipefail
11+
12+
export PATH="/usr/local/node/bin:$PATH"
13+
14+
(
15+
cd python/ray/dashboard/client
16+
17+
echo "--- npm ci"
18+
npm ci
19+
20+
echo "--- npm run build"
21+
npm run build
22+
23+
tar -czf /home/forge/dashboard.tar.gz -C build .
24+
)
25+
26+
EOF
27+
28+
FROM scratch
29+
30+
COPY --from=builder /home/forge/dashboard.tar.gz /dashboard.tar.gz

ci/docker/ray-dashboard.wanda.yaml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
name: ray-dashboard
2+
froms: ["cr.ray.io/rayproject/manylinux"]
3+
dockerfile: ci/docker/ray-dashboard.Dockerfile
4+
srcs:
5+
- python/ray/dashboard/client/

0 commit comments

Comments
 (0)