Skip to content

Commit d93bdc4

Browse files
committed
Revert "Support generic default values"
This feature inadvertently introduced a breaking change (#144) This reverts commits: feb6c4b b38a553.
1 parent 1610294 commit d93bdc4

File tree

3 files changed

+1
-27
lines changed

3 files changed

+1
-27
lines changed

schemars/tests/default.rs

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -56,15 +56,3 @@ struct NotSerialize;
5656
fn schema_default_values() -> TestResult {
5757
test_default_generated_schema::<MyStruct>("default")
5858
}
59-
60-
#[allow(dead_code)]
61-
#[derive(JsonSchema)]
62-
struct StructWithGenericDefaults {
63-
#[serde(default = "Vec::new")]
64-
a_vec: Vec<String>,
65-
}
66-
67-
#[test]
68-
fn schema_with_generic_default_value() -> TestResult {
69-
test_default_generated_schema::<StructWithGenericDefaults>("generic_default")
70-
}

schemars/tests/expected/generic_default.json

Lines changed: 0 additions & 14 deletions
This file was deleted.

schemars_derive/src/schema_exprs.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -581,7 +581,7 @@ fn field_default_expr(field: &Field, container_has_default: bool) -> Option<Toke
581581
quote!(container_default.#member)
582582
}
583583
SerdeDefault::Default => quote!(<#ty>::default()),
584-
SerdeDefault::Path(path) => quote!({ #path() as #ty }),
584+
SerdeDefault::Path(path) => quote!(#path()),
585585
};
586586

587587
let default_expr = match field.serde_attrs.skip_serializing_if() {

0 commit comments

Comments
 (0)