forked from demisto/content
-
Notifications
You must be signed in to change notification settings - Fork 0
Generic cmnd contrib service nowv2 #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Geekverma
merged 77 commits into
Geekverma:master
from
shubham-sudo:Generic-cmnd-contrib-ServiceNowv2
Feb 25, 2022
Merged
Generic cmnd contrib service nowv2 #1
Geekverma
merged 77 commits into
Geekverma:master
from
shubham-sudo:Generic-cmnd-contrib-ServiceNowv2
Feb 25, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix zscaler 406 keyerror message * Update Zscaler_test.py * Update Zscaler_test.py * fix lint issues * Update 1_1_17.md * Update Packs/Zscaler/ReleaseNotes/1_1_17.md Co-authored-by: Itay Keren <[email protected]> Co-authored-by: Itay Keren <[email protected]>
* Update dbot_score for url command * Done write code&tests url command * Changed Domain command dbot score calculation * Added to domain command relationships & tags * Change file dbot score calculation * Added file relationships * Done unitests & updated yaml file context output * Updated TestPlaybook * deleted temp playbook test * Update readme file & release note * Added doc & tests * Updated release note * Fixed tests * Fixed tests * Fixed build issues * Updated test playbook * Fixed several files * Apply suggestions from code review Co-authored-by: Dan Tavori <[email protected]> * Apply suggestions from code review Co-authored-by: Dan Tavori <[email protected]> * Apply suggestions from code review Co-authored-by: Dan Tavori <[email protected]> * Fixing from the code review * Updated domain command * Fixed type hints and updated file command * Fixed testplaybook * Rerun build * Rerun build * Updated README * Updated README * Fixed README * Fixed testplaybook * Fixed testplaybook * Updated the commands to support several * Rerun build * Rerun build * Fixed notes from CR * Fixed notes from CR * Update 1_0_13.md Done. * Update URLHaus_description.md Done. * Update README.md Done. * Update URLHaus.yml Done. * Updates from demo Co-authored-by: Dan Tavori <[email protected]> Co-authored-by: ShirleyDenkberg <[email protected]>
* basic filter * ut, behavior change * rn, version * type * Update Packs/CommonScripts/ReleaseNotes/1_6_36.md Co-authored-by: Shai Yaakovi <[email protected]> * CR * trimevent is an getIncident arg * bump version * rename to trimevents, ignore if trimevents=0 * description * UT Co-authored-by: Shai Yaakovi <[email protected]>
* aliases * aliases
* CortexCoreIR * CoreIOCs * blocklist * blocklist * status * status * lint * test * test * whitelist * report_incorrect_wildfire_command * master_key * no fetch and feed * polling * tests * flake8 * mypy * “TriggerBuild” * validate * master_key * validate * demo * demo * apicall * getLicenseCustomField * new files * new commands and token * new commands and token * tests * lint * demo changes * unitests * docs * wildfire * quarantine-files * secrets * test without fetch * Trigger Build * cr * cr * cr * Sync Incident Owners * edited desriptions * docs review * final * new command and fix readme * version removed Co-authored-by: jrosenpanw <[email protected]>
* added support for OOTB license * added support for OOTB license * moved validation to test module * moved validation to test module * moved validation to test module * Fixed logic to only support X2 * final version with CR fixes
* ci(dependencies): add dependabot config * fix(dependabot): rm client dir * fix(infra): rm dev_envs dir
* Update README.md Removed Multi-Factor Authentication from the integration instructions. Added note to use EWS O365, O365 Outlook Mail (Using Graph API), or O365 Outlook Mail Single User (Using Graph API) instead. * Made link HTML links Co-authored-by: yaakovi <[email protected]>
* url bug fix * update RN * Update Packs/Anomali_ThreatStream/ReleaseNotes/2_0_6.md Co-authored-by: Shai Yaakovi <[email protected]> * added q to url Co-authored-by: Shai Yaakovi <[email protected]>
* First commit * Added get_range_command & tests * Added get_range_command & tests * Create get_range_command * Fixed bugs get_range_command * Fixed error * Updated Release notes * Updated docker image * Fixed output * Rerun build * Apply suggestions from code review Co-authored-by: Dan Tavori <[email protected]> * Updates from CR Co-authored-by: Dan Tavori <[email protected]>
* failed test * failed test * possible solution * possible solution * release notes and metadata * changes after cr * removed uneeded raw response * updated tests * changes after cr * updated raw response * removed sensitive data
* Update readme and metadata text (demisto#17712) * Update readme and metadata text * Fix typo in resolutionprocess * Use the updated copy from marketing team * Add release note * added docker image update to RN * docker image update to integration * revert mistaken changed file * revert mistaken changed file * dummy Co-authored-by: Long Tan <[email protected]> Co-authored-by: yucohen <[email protected]>
* added new command delete attribute * add to readme * added new command to TBP * add RN * update RN * fix RN
…to#17704) * added iteration in batches * added rn * added iteration in batches phase 2 * added iteration in batches for samples * update RN * CR fixes * added tests * resolve conflict in RN * resolve conflict in RN * add docstring to tests * improve description * Update Packs/AutoFocus/Integrations/AutofocusV2/AutofocusV2.yml Co-authored-by: Dan Tavori <[email protected]> Co-authored-by: Dan Tavori <[email protected]>
* add space * update RN after merge master * triger build * update RN after merge master
* Adding an additional command * PR Ready * Current version update * Adding the id argument back. * Adding test unit * fixing test unit * Keeping the old argument order. * Changing the command order. Co-authored-by: Ayman Mahmoud <[email protected]>
…to#17773) * Initial version of Trustwave Fusion Integration * Minor updates * Update githubUser in pack_metadata.json Handle empty responses better by adding messages to human readable output. Remove uneeded exception handling. Add unit tests, fix close ticket command. Generate README.md. * Fix lint errors. * Add unit tests to improve coverage. * Update product description. * Handle the case where finding status is none. * Update description for README and fix ticket command descriptions. Co-authored-by: Craig Forbes <[email protected]> Co-authored-by: merit <[email protected]>
* added support to parse date * little fixes * changing release notes * updated docker image * added custom context parameter * fixed release notes * renamed argument * renamed argument * typo fix * fixes from pr * format yml file * changed release notes * updated release notes * updated release notes one more time
* ignoring image dimensions
* Updated Metadata Of Pack GoogleBigQuery * Added release notes to pack GoogleBigQuery * Packs/GoogleBigQuery/Integrations/GoogleBigQuery/GoogleBigQuery.yml Docker image update
* Updated Metadata Of Pack FeedAzureADConnectHealth * Added release notes to pack FeedAzureADConnectHealth * Packs/FeedAzureADConnectHealth/Integrations/AzureADConnectHealthFeed/AzureADConnectHealthFeed.yml Docker image update * Updated Metadata Of Pack FeedMicrosoftIntune * Added release notes to pack FeedMicrosoftIntune * Packs/FeedMicrosoftIntune/Integrations/FeedMicrosoftIntune/FeedMicrosoftIntune.yml Docker image update * Updated Metadata Of Pack jamf * Added release notes to pack jamf * Packs/jamf/Integrations/jamfV2/jamfV2.yml Docker image update Co-authored-by: sberman <[email protected]>
* add commands * add commands * add commands * add commands * add commands * add tests * small changes * fixed yml * Update examples.txt * fixed yml * fixed yml * fixed tests * fixed yml * fixed yml * fixed yml * fixed yml * fixed yml * fixed yml * cr & demo fixes * cr & demo fixes * cr & demo fixes * cr & demo fixes * cr & demo fixes * cr & demo fixes * cr & demo fixes
* Fix script command dependency * Deprecate AdGetUser * Fix cr comments
* add log and removed tag * release * IN129 * Update Packs/Core/ReleaseNotes/1_0_1.md Co-authored-by: yuvalbenshalom <[email protected]>
* Updated Metadata Of Pack CarbonBlackDefense * Added release notes to pack CarbonBlackDefense * Packs/CarbonBlackDefense/Integrations/CarbonBlackLiveResponseCloud/CarbonBlackLiveResponseCloud.yml Docker image update
* added credentials * added RN * ignore IN124 * updated rn * edit yml * renamed the apikey param
* Adding an additional partition argument to all commands. (demisto#17809) * Adding an additional partition argument to all commands. * Update the docker image version. * added docker image update to RN and added LTM to known words Co-authored-by: Ayman Mahmoud <[email protected]> Co-authored-by: yucohen <[email protected]>
* Updated Metadata Of Pack Cisco-umbrella-enforcement * Added release notes to pack Cisco-umbrella-enforcement * Packs/Cisco-umbrella-enforcement/Integrations/CiscoUmbrellaEnforcement/CiscoUmbrellaEnforcement.yml Docker image update * Updated Metadata Of Pack CiscoASA * Added release notes to pack CiscoASA * Packs/CiscoASA/Integrations/CiscoASA/CiscoASA.yml Docker image update * Updated Metadata Of Pack CrowdStrikeMalquery * Added release notes to pack CrowdStrikeMalquery * Packs/CrowdStrikeMalquery/Integrations/CrowdStrikeMalquery/CrowdStrikeMalquery.yml Docker image update * Updated Metadata Of Pack Cryptocurrency * Added release notes to pack Cryptocurrency * Packs/Cryptocurrency/Integrations/Cryptocurrency/Cryptocurrency.yml Docker image update * Updated Metadata Of Pack DeveloperTools * Added release notes to pack DeveloperTools * Packs/DeveloperTools/Integrations/CustomIndicatorDemo/CustomIndicatorDemo.yml Docker image update * Updated Metadata Of Pack EmailRepIO * Added release notes to pack EmailRepIO * Packs/EmailRepIO/Integrations/EmailRepIO/EmailRepIO.yml Docker image update * Updated Metadata Of Pack F5 * Added release notes to pack F5 * Packs/F5/Integrations/F5_ASM/F5_ASM.yml Docker image update * Updated Metadata Of Pack F5Silverline * Added release notes to pack F5Silverline * Packs/F5Silverline/Integrations/F5Silverline/F5Silverline.yml Docker image update * Updated Metadata Of Pack FeedAlienVault * Added release notes to pack FeedAlienVault * Packs/FeedAlienVault/Integrations/FeedAlienVaultReputation/FeedAlienVaultReputation.yml Docker image update * Updated Metadata Of Pack FeedAzure * Added release notes to pack FeedAzure * Packs/FeedAzure/Integrations/FeedAzure/FeedAzure.yml Docker image update
…#17790) * add else option for 'rsa-nw-snapshots-list-for-host' command * cr fix
* fix RE when calculating headers for readable output * CR changes
* Added new parameter and argument "scan_visbility" (demisto#17736) * Added new parameter and argument "scan_visbility" * Updated release notes * Update Packs/UrlScan/Integrations/UrlScan/UrlScan.py Co-authored-by: yucohen <[email protected]> * Update Packs/UrlScan/Integrations/UrlScan/UrlScan.yml Co-authored-by: Bar Katzir <[email protected]> * Update Packs/UrlScan/Integrations/UrlScan/UrlScan.yml Co-authored-by: Bar Katzir <[email protected]> * Update Packs/UrlScan/ReleaseNotes/1_1_16.md Co-authored-by: Bar Katzir <[email protected]> Co-authored-by: yucohen <[email protected]> Co-authored-by: Bar Katzir <[email protected]> * RN * Update 1_1_17.md update rn Co-authored-by: Adam Burt - Demisto <[email protected]> Co-authored-by: yucohen <[email protected]> Co-authored-by: Bar Katzir <[email protected]> Co-authored-by: yucohen <[email protected]>
) * Full ReversingLabs Ransomware and Related Tools Feed integration folder migration * YML correction * Readme update * Reverted the version to 1.0.0 * Added an IP address to .secrets-ignore * Updated the dockerimage * Changed 'Hash' to 'hash' * Changed 'Hash' to 'hash' * Added file_info and asn Rearranged the create_indicator_object() function * Updated the unit tests * Updated the ignored secrets * Removed a leftover print statement * Updated the integration readme * Updated the .secrets-ignore * Updated the unit tests * Removed the price Co-authored-by: Mislav Sever <[email protected]> Co-authored-by: content-bot <[email protected]> Co-authored-by: Mislav Sever <[email protected]>
* first commit * working on the first commandds of Google Sheets * commit of changes * changes in yml after adding auto pre - unit tests - starting to work again on connection issues * this is a working version of the pack with the google.ouath2 moudule * this is a commit in the new branch * moving to google sheets branch and deleting it * commit outh * commit in google shhets * adding opion for user delegation * adding the google drive delete to the test play book - removing the static decorator and changing the test command * before PR * adg the Test.conf settings * lint fixes * for new build test * for new build test * change of is instance in the build_authenticate in order to support the diffarence between the build and local * add comment to triger build * add commit to trigger the build * changed the Test/conf.json to give the google docker image more thresh-hold storage , modified the google sheets integration back to the type 9 service account credentials * empty commit to triger build * changes in the the values description in the yml * removed some unneseccery comments * Update Packs/GoogleSheets/Integrations/GoogleSheets/Pipfile review changes Co-authored-by: Dan Sterenson <[email protected]> * Update Packs/GoogleSheets/Integrations/GoogleSheets/GoogleSheets.yml Co-authored-by: Dan Sterenson <[email protected]> * Update Packs/GoogleSheets/Integrations/GoogleSheets/GoogleSheets.yml Co-authored-by: Dan Sterenson <[email protected]> * Update Packs/GoogleSheets/Integrations/GoogleSheets/GoogleSheets.yml Co-authored-by: Dan Sterenson <[email protected]> * Update Packs/GoogleSheets/Integrations/GoogleSheets/GoogleSheets.yml Co-authored-by: Dan Sterenson <[email protected]> * Update Packs/GoogleSheets/Integrations/GoogleSheets/GoogleSheets.yml Co-authored-by: Dan Sterenson <[email protected]> * Update Packs/GoogleSheets/Integrations/GoogleSheets/GoogleSheets.py Co-authored-by: Dan Sterenson <[email protected]> * commit * fixes from the review * Update Packs/GoogleSheets/Integrations/GoogleSheets/GoogleSheets.yml Co-authored-by: Dan Sterenson <[email protected]> * adding support for the value error exception to help the user enter the data correctly - adding the fitting tests * added comments to the sheets_data_paste function * changed the documentation to be in the Google Style python docstring ang chnaged the yml explenation of the spreadsheet update * changes in the conf.json * review changes * changed names of the functions to fit the convention * modified the description page * added a function for the output of the context * added a function to test the new get response to markdown * a lot of changes after demo * generated a readme file added example commands, fixed some bugs in the yml * added known limitations to the readme * erased an empty response.json file in test matrix * Update GoogleSheets_description.md Done. * Update GoogleSheets.yml Done. * Update README.md Done. * modified yml after demo, added a function to set a defaul range if not specified and test function as well * changed range to be from A1, added a desc to the get ranges * Update Packs/GoogleSheets/Integrations/GoogleSheets/GoogleSheets.py Co-authored-by: Shai Yaakovi <[email protected]> * added authentication to the service account * changes after Shai review 2 * changes after Shai review 2 * small cahnge to return None in default_ranges_if_not_specified * reverted changes in Test/conf.json * changes after Shai review * changed threshold to 200mb * added the threshold again * Update Packs/GoogleSheets/Integrations/GoogleSheets/GoogleSheets.py Co-authored-by: Shai Yaakovi <[email protected]> * Apply suggestions from code review no cover tetsts Co-authored-by: Shai Yaakovi <[email protected]> * Update Packs/GoogleSheets/Integrations/GoogleSheets/GoogleSheets.py Co-authored-by: Shai Yaakovi <[email protected]> * added pragma: no cover and merged from master * changes images size for new image validation Co-authored-by: Dan Sterenson <[email protected]> Co-authored-by: ShirleyDenkberg <[email protected]> Co-authored-by: Shai Yaakovi <[email protected]>
* fixed bug in update script * Update RN
* implement network setup * updaed dind image * added us-west1 tag Co-authored-by: esharf <[email protected]>
* adding cdefdentials * adding cred * adding cred * minor changes * minor fixes * added tests and RN * merged from master * added word to known words * ignore IN124 * added ignore IN124 * edited rn * edit yml * added new rn * added IN124 to pack-ignore * Update 1_3_14.md * Update 1_3_14.md * Update 1_3_14.md * Update 1_3_14.md * changes * changes * changes Co-authored-by: Shahaf Ben Yakir <[email protected]>
* cs falcon ioc * update tests * update secrets * update rn * update secrets * fix unitest * fix flake8 and mypy * mypy ignore * fix lint and validate * merge from master * merge from master * fix CR * fix docs
* added credentials set * added credentials * added RN * renamed apikey param
…7753) * feat(output): added the itype output to the reputation commands * metadata(release-notes): ignore known words
* new fetch * cr & demo fixes * cr & demo fixes * cr & demo fixes * cr & demo fixes * cr & demo fixes * changed mapping * changed mapping * changed mapping * added RN * fix mapper * fix mapper * Update Packs/MicrosoftDefenderAdvancedThreatProtection/Integrations/MicrosoftDefenderAdvancedThreatProtection/MicrosoftDefenderAdvancedThreatProtection.yml Co-authored-by: Dean Arbel <[email protected]> * Update MicrosoftDefenderAdvancedThreatProtection.py * fix mapper * fix create instance error * fix create instance error * fix create instance error * fix mapper * fix mapper * fix mapper * fix mapper Co-authored-by: Dean Arbel <[email protected]>
* Solving bug at the ML page when query is empty * Added RNs * Update docker images
* revert deletion of incident-field * revert deletion of incident-field * revert deletion of incident-field * revert deletion of incident-field
… Geekverma-contrib-ServiceNow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes:
Description
Updated to resolve circleci build failing issues to PR-17731
Screenshots
Paste here any images that will help the reviewer
Minimum version of Cortex XSOAR
Does it break backward compatibility?
Must have