Skip to content

PyGMT version is not dynamic in develop mode? #912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
seisman opened this issue Feb 16, 2021 · 4 comments
Closed

PyGMT version is not dynamic in develop mode? #912

seisman opened this issue Feb 16, 2021 · 4 comments
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@seisman
Copy link
Member

seisman commented Feb 16, 2021

Full code that generated the error

I have the full git repository of the PyGMT project, and then run the following commands:

# Checkout master branch and install it
$ cd pygmt/
$ git checkout master
$ make install

# Check current PyGMT version
$ python -c "import pygmt; print(pygmt.__version__)"
v0.3.1.dev3+g27c09271

# Checkout the v0.3.0 tag and check the PyGMT version
$ git checkout v0.3.0
HEAD is now at 65b099a5 Changelog entry for v0.3.0 (#887)
$ python -c "import pygmt; print(pygmt.__version__)"
v0.3.1.dev3+g27c09271

As shown above, should the version string to v0.3.0 when I checked out the v0.3.0 tag?

@seisman seisman added the bug Something isn't working label Feb 16, 2021
@seisman
Copy link
Member Author

seisman commented Feb 21, 2021

Related to pypa/setuptools-scm#518

@weiji14
Copy link
Member

weiji14 commented Nov 3, 2021

Don't think there's much we can do with this, other than using post commit/checkout hooks as mentioned in pypa/setuptools-scm#518 (comment). Maybe something that could be added to #1593.

Closing for now.

@weiji14 weiji14 closed this as completed Nov 3, 2021
@weiji14 weiji14 added the wontfix This will not be worked on label Nov 3, 2021
@seisman
Copy link
Member Author

seisman commented Apr 8, 2024

@seisman seisman reopened this Apr 8, 2024
@seisman
Copy link
Member Author

seisman commented Apr 10, 2024

Changed my mind and I think we should use the more official setuptools_scm although it has some limitations. Close again.

@seisman seisman closed this as completed Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants