Make comparison of CanonicalName case insensitive

Author: asbjornu

src/GitVersionCore/Core/RepositoryMetadataProvider.cs

@@ -184,9 +184,9 @@ public Branch GetTargetBranch(string targetBranch)
                     // In the case where HEAD is not the desired branch, try to find the branch with matching name
                     desiredBranch = repository.Branches?
                         .SingleOrDefault(b =>
-                            b.CanonicalName == targetBranch ||
-                            b.FriendlyName == targetBranch ||
-                            b.NameWithoutRemote() == targetBranch);
+                            b.CanonicalName.IsEquivalentTo(targetBranch) ||
+                            b.FriendlyName.IsEquivalentTo(targetBranch) ||
+                            b.NameWithoutRemote().IsEquivalentTo(targetBranch));
 
                     // Failsafe in case the specified branch is invalid
                     desiredBranch ??= repository.Head;

src/GitVersionCore/Extensions/RepositoryExtensions.cs

@@ -54,7 +54,7 @@ public static void EnsureLocalBranchExistsForCurrentBranch(this IRepository repo
 
             var repoTipId = repoTip.Id;
 
-            if (repo.Branches.All(b => b.CanonicalName != localCanonicalName))
+            if (repo.Branches.All(b => !String.Equals(b.CanonicalName, localCanonicalName, StringComparison.OrdinalIgnoreCase)))
             {
                 log.Info(isBranch ? $"Creating local branch {localCanonicalName}"
                     : $"Creating local branch {localCanonicalName} pointing at {repoTipId}");
@@ -142,8 +142,11 @@ public static void CreateOrUpdateLocalBranchesFromRemoteTrackingOnes(this IRepos
         {
             var prefix = $"refs/remotes/{remoteName}/";
             var remoteHeadCanonicalName = $"{prefix}HEAD";
+            var remoteTrackingReferences = repo.Refs
+                .FromGlob(prefix + "*")
+                .Where(r => !r.CanonicalName.IsEquivalentTo(remoteHeadCanonicalName));
 
-            foreach (var remoteTrackingReference in repo.Refs.FromGlob(prefix + "*").Where(r => r.CanonicalName != remoteHeadCanonicalName))
+            foreach (var remoteTrackingReference in remoteTrackingReferences)
             {
                 var remoteTrackingReferenceName = remoteTrackingReference.CanonicalName;
                 var branchName = remoteTrackingReferenceName.Substring(prefix.Length);
@@ -152,7 +155,7 @@ public static void CreateOrUpdateLocalBranchesFromRemoteTrackingOnes(this IRepos
                 // We do not want to touch our current branch
                 if (branchName == repo.Head.FriendlyName) continue;
 
-                if (repo.Refs.Any(x => x.CanonicalName == localCanonicalName))
+                if (repo.Refs.Any(x => x.CanonicalName.IsEquivalentTo(localCanonicalName)))
                 {
                     var localRef = repo.Refs[localCanonicalName];
                     var remotedirectReference = remoteTrackingReference.ResolveToDirectReference();

src/GitVersionCore/Extensions/StringExtensions.cs

@@ -129,5 +129,10 @@ public static string RegexReplace(this string input, string pattern, string repl
         {
             return Regex.Replace(input, pattern, replace, options);
         }
+
+        public static bool IsEquivalentTo(this string self, string other)
+        {
+            return String.Equals(self, other, StringComparison.OrdinalIgnoreCase);
+        }
     }
 }