Skip to content

Commit d544448

Browse files
committed
All tags on master affect develops version. This addresses #796
1 parent 62bf7de commit d544448

File tree

4 files changed

+6
-8
lines changed

4 files changed

+6
-8
lines changed

src/GitVersionCore.Tests/IntegrationTests/ReleaseBranchScenarios.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,10 @@ public void NoMergeBacksToDevelopInCaseThereAreNoChangesInReleaseBranch()
2020
fixture.Repository.MergeNoFF("release/1.0.0");
2121
fixture.Repository.ApplyTag("1.0.0");
2222
fixture.Repository.Checkout("develop");
23-
fixture.Repository.MakeACommit();
2423

2524
fixture.Repository.Branches.Remove(releaseBranch);
2625

27-
fixture.AssertFullSemver("1.1.0-alpha.1");
26+
fixture.AssertFullSemver("1.1.0-alpha.0");
2827
}
2928
}
3029

src/GitVersionCore/GitVersionCore.csproj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,6 @@
139139
<Compile Include="VersionCalculation\BaseVersionCalculator.cs" />
140140
<Compile Include="VersionCalculation\BaseVersionCalculators\BaseVersion.cs" />
141141
<Compile Include="VersionCalculation\BaseVersionCalculators\ConfigNextVersionBaseVersionStrategy.cs" />
142-
<Compile Include="VersionCalculation\BaseVersionCalculators\TrackMergeTargetBaseVersionStrategy.cs" />
143142
<Compile Include="VersionCalculation\BaseVersionCalculators\TaggedCommitVersionStrategy.cs" />
144143
<Compile Include="VersionCalculation\BaseVersionCalculators\MergeMessageBaseVersionStrategy.cs" />
145144
<Compile Include="VersionCalculation\BaseVersionCalculators\VersionInBranchBaseVersionStrategy.cs" />

src/GitVersionCore/VersionCalculation/BaseVersionCalculators/TaggedCommitVersionStrategy.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
namespace GitVersion.VersionCalculation.BaseVersionCalculators
22
{
3+
using System;
34
using System.Collections.Generic;
45
using System.Linq;
56
using LibGit2Sharp;
@@ -8,14 +9,13 @@ public class TaggedCommitVersionStrategy : BaseVersionStrategy
89
{
910
public override IEnumerable<BaseVersion> GetVersions(GitVersionContext context)
1011
{
11-
return GetTaggedVersions(context, context.CurrentBranch);
12+
return GetTaggedVersions(context, context.CurrentBranch, context.CurrentCommit.When());
1213
}
1314

14-
public IEnumerable<BaseVersion> GetTaggedVersions(GitVersionContext context, Branch currentBranch)
15+
public IEnumerable<BaseVersion> GetTaggedVersions(GitVersionContext context, Branch currentBranch, DateTimeOffset? olderThan)
1516
{
16-
var olderThan = context.CurrentCommit.When();
1717
var allTags = context.Repository.Tags
18-
.Where(tag => ((Commit) tag.PeeledTarget()).When() <= olderThan)
18+
.Where(tag => !olderThan.HasValue || ((Commit) tag.PeeledTarget()).When() <= olderThan.Value)
1919
.ToList();
2020
var tagsOnBranch = currentBranch
2121
.Commits

src/GitVersionCore/VersionCalculation/DevelopVersionStrategy.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ private IEnumerable<BaseVersion> MasterTagsVersions(GitVersionContext context)
3030
var master = context.Repository.FindBranch("master");
3131
if (master != null)
3232
{
33-
return taggedCommitVersionStrategy.GetTaggedVersions(context, master);
33+
return taggedCommitVersionStrategy.GetTaggedVersions(context, master, null);
3434
}
3535

3636
return new BaseVersion[0];

0 commit comments

Comments
 (0)