Skip to content

NuGet GitVersion.CommandLine #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JakeGinnivan opened this issue May 28, 2014 · 9 comments
Closed

NuGet GitVersion.CommandLine #182

JakeGinnivan opened this issue May 28, 2014 · 9 comments

Comments

@JakeGinnivan
Copy link
Contributor

I am installing GitVersion on my build server via chocolatey, but maybe we should offer a GitVersion.CommandLine for people who want to install into the repo.

Then should we leave it in the packages folder, or should it copy itself into a tools folder or something like that?

@andreasohlund
Copy link
Contributor

Since /packages has the version in the path I'm +1 for copying it!

Sent from my iPhone

On 28 May 2014, at 21:39, Jake Ginnivan [email protected] wrote:

I am installing GitVersion on my build server via chocolatey, but maybe we should offer a GitVersion.CommandLine for people who want to install into the repo.

Then should we leave it in the packages folder, or should it copy itself into a tools folder or something like that?


Reply to this email directly or view it on GitHub.

@pvandervelde
Copy link

Assuming you mean a NuGet package for GitVersion.CommandLine? I'd definitely love to have that given that this is how I use GitHubFlowVersion at the moment and I'm looking to switch to GitVersion as soon as possible.

However I'd say do not copy the package into a tools folder because:
a) Most importantly I would like to be in control over the layout of my workspace / repository. On of my personal pet hates is when package owners decide that their code is different from all the other packages and thus they 'deserve' to determine where their code should live.
b) I don't want to have to add to my .gitignore because some package decided to copy itself outside my packages folder.
c) Dealing with the version in /packages is something I have to do for all the other tools anyway. It's a solved problem (at least for my build), however having to provide yet another path where tools may live means I have to change my build scripts.

@andreasohlund
Copy link
Contributor

Good points!

Sent from my iPhone

On 28 May 2014, at 23:24, Petrik van der Velde [email protected] wrote:

Assuming you mean a NuGet package for GitVersion.CommandLine? I'd definitely love to have that given that this is how I use GitHubFlowVersion at the moment and I'm looking to switch to GitVersion as soon as possible.

However I'd say do not copy the package into a tools folder because:
a) Most importantly I would like to be in control over the layout of my workspace / repository. On of my personal pet hates is when package owners decide that their code is different from all the other packages and thus they 'deserve' to determine where their code should live.
b) I don't want to have to add to my .gitignore because some package decided to copy itself outside my packages folder.
c) Dealing with the version in /packages is something I have to do for all the other tools anyway. It's a solved problem (at least for my build), however having to provide yet another path where tools may live means I have to change my build scripts.


Reply to this email directly or view it on GitHub.

@JakeGinnivan
Copy link
Contributor Author

#190 fixes this

@pvandervelde
Copy link

Any idea when this will be released? I'm waiting for this issue (and hoping for #137) to switch from GitHubFlowVersion to GitVersion.

@pvandervelde
Copy link

@JakeGinnivan @andreasohlund any thoughts on a release date?

@JakeGinnivan
Copy link
Contributor Author

Just done a bunch of doco, am working on the open pull requests and then maybe an issue or two. Then release. So a day or two

@pvandervelde
Copy link

Sweet. Looking forward to it :)

@JakeGinnivan
Copy link
Contributor Author

While you are waiting, if you wanted to look through the doco and post any issues you find at #220 that would be super helpful :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants