-
Notifications
You must be signed in to change notification settings - Fork 651
Wrong version being calculated for feature branch #788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Oh this was with Gitversion.commandline 3.1.2 but I just tried with 3.4.1 and it gives the same results. |
Looks like a scenario our tests don't cover. The way I sort these issues out is I write a test replicating the issue by asserting the versions I would expect. Then I try and fix it :P A PR with a failing test (or completely fixing the issue) is welcome, but the test is a real time saver when i pick up these sort of issues |
I'll see if I have some time but we're in the middle of TFS upgrades and releases so I'm kinda snowed under at the moment :( |
Am I correct in thinking that my case is nearly the same as described in the If so I can add create a test with a pull request |
I'm having a similar issue using gitflow however I get the message "Merge base was due to a forward merge, moving to next merge base". I'm using SourceTree to manage my feature branches and the problem seems to be caused when we merge a release branch into master without committing a change to the release branch. In this case the gitflow merge only merges the release branch to master and not into develop. When we create a feature branch from develop after this merge the version falls to the version that was last merged into the develop branch from master. However, commits that happen directly on the develop branch do get the correct version number. |
Yes I've seen that one same problem as well. |
I posted a failed test PR for it. |
Fixed by #832 |
Thoughts on |
State of repository
Now I'm trying to build on a feature branch and I get the following result
The log file looks like:
And from that it looks like it doesn't find any reference what so ever to 1.1.0.
So now the question is where did I go wrong. I've been using sourcetree and the build in gitflow feature so I don't think I stuffed up the workflow but could have. Any suggestions on why this happened?
Also I'm guessing as soon as I merge this change to develop and then create a release branch it will all sort itself out, but I would like to prevent this issue from happening again.
The text was updated successfully, but these errors were encountered: