Spike showing new CLI usage - got one command working #2263
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| using GitVersion.Extensions; | ||
| using GitVersion.Logging; | ||
| using System; | ||
| using System.CommandLine; | ||
| using System.CommandLine.Invocation; | ||
| using System.Threading.Tasks; | ||
|
|
||
| namespace GitVersion | ||
| { | ||
|
|
||
| public class CalculateCommand : Command | ||
| { | ||
| private readonly Logging.IConsole console; | ||
| private readonly IGitVersionTool gitversionTool; | ||
| private readonly GitVersionCommandExecutor executor; | ||
|
|
||
| public CalculateCommand(Logging.IConsole console, IGitVersionTool gitversionTool, GitVersionCommandExecutor executor) : base("calculate", "Calculates version information from your git repository") | ||
| { | ||
| this.console = console; | ||
| this.gitversionTool = gitversionTool; | ||
| this.executor = executor; | ||
| this.AddOption(new Option<bool>( | ||
| "--normalize", | ||
| "Attempt to mutate your git repository so gitversion has enough information (local branches, commit history etc) to calculate.")); | ||
| this.Handler = CommandHandler.Create<GlobalCommandOptions, bool?>(ExecuteAsync); | ||
| } | ||
|
|
||
| private async Task<int> ExecuteAsync(GlobalCommandOptions globalOptions, bool? normalize) | ||
| { | ||
| // The executor wraps execution of the command logic inside somethng that | ||
| // will do error handling according to the old behaviour. | ||
| return await executor.Execute(globalOptions, async () => | ||
| { | ||
| if (normalize ?? false) | ||
| { | ||
| await Normalize(); | ||
| } | ||
|
|
||
| var variables = this.gitversionTool.CalculateVersionVariables(); | ||
| console.WriteLine(variables.ToString()); | ||
| return 0; | ||
| }); | ||
| } | ||
|
|
||
| private Task Normalize() | ||
| { | ||
| throw new NotImplementedException(); | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note:
ProjectRootDirectorywas actually being set to the "working directory" of the git repository. This is different from the command line's working directory, or the directory of the.gitfolder. I renamed it toGitRepositoryWorkingDirectoryto aid understanding whilst refactoring. It's not a critical change.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been a constant source of friction, because I think it's used to support dynamic repositories in a weird way I don't quite understand. I think it's been changed back and forth several times in different PR's, each breaking one other use case that isn't well enough tested. 🤷♂️