Skip to content

Commit 397da6b

Browse files
committed
Redo experiment 1 with current beta and nightly
When using `dtolnay/rust-toolchain` with the `toolchain` key to specify a channel, the action version should be given as `@master`. But I accidentally kept it at `@stable`! This caused `beta` and `nightly` to refer to the most recent beta and nightly builds *prior* to the current stable version. That made the conclucions about beta and nightly builds inaccurate. This rectifies that error and repeats the experiment. See e71b0cf (1f3f6b5), #1790, and rust-lang/rust#135867 for context. (I made this mistake in both experiment 1 and experiment 2, having wrongly thought I'd changed `@stable` to `@master` for experiment 1. This commit just repeats experiment 1, but experiment 2 should also be repeated for the same reason.)
1 parent 1b3e2cd commit 397da6b

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

.github/workflows/arm-segv-experiment.yml

+6-6
Original file line numberDiff line numberDiff line change
@@ -6,27 +6,27 @@ jobs:
66
test-fast:
77
strategy:
88
matrix:
9-
num-high: [ 0, 1, 2, 3, 4, 5, 6, 7 ]
109
os-ver: [ '22.04', '24.04' ]
1110
channel: [ stable, beta ] # `gix-macros::macros momo::ux` currently fails on `nightly`.
12-
num-low: [ 0, 1, 2, 3, 4, 5, 6, 7 ]
11+
increase-stack: [ false, true ]
12+
number: [ '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', 'A', 'B', 'C', 'D', 'E', 'F' ]
1313

1414
fail-fast: false
1515

1616
runs-on: ubuntu-${{ matrix.os-ver }}-arm
1717

1818
steps:
1919
- uses: actions/checkout@v4
20-
- uses: dtolnay/rust-toolchain@stable
20+
- uses: dtolnay/rust-toolchain@master
2121
with:
2222
toolchain: ${{ matrix.channel }}
2323
# - uses: Swatinem/rust-cache@v2
2424
- uses: taiki-e/install-action@v2
2525
with:
2626
tool: nextest
27-
# - name: Set RUST_MIN_STACK
28-
# if: matrix.increase-stack
29-
# run: echo RUST_MIN_STACK=16777216 >>"$GITHUB_ENV"
27+
- name: Set RUST_MIN_STACK
28+
if: matrix.increase-stack
29+
run: echo RUST_MIN_STACK=16777216 >>"$GITHUB_ENV"
3030
- name: Test (nextest)
3131
env:
3232
GIX_TEST_CREATE_ARCHIVES_EVEN_ON_CI: '1'

0 commit comments

Comments
 (0)