Merge pull request #2249 from iczero/fetch-performance-fix

Byron · web-flow · commit c3beb202fbb4 · 2025-11-07T04:51:11.000+01:00
Move worktree_branches call out of loop in ref update
diff --git a/gix/src/remote/connection/fetch/update_refs/mod.rs b/gix/src/remote/connection/fetch/update_refs/mod.rs
@@ -76,6 +76,7 @@ pub(crate) fn update(
     let mut updates = Vec::new();
     let mut edit_indices_to_validate = Vec::new();
 
+    let mut checked_out_branches = worktree_branches(repo)?;
     let implicit_tag_refspec = fetch_tags
         .to_refspec()
         .filter(|_| matches!(fetch_tags, crate::remote::fetch::Tags::Included));
@@ -110,7 +111,6 @@ pub(crate) fn update(
                 continue;
             }
         }
-        let mut checked_out_branches = worktree_branches(repo)?;
         let (mode, edit_index, type_change) = match local {
             Some(name) => {
                 let (mode, reflog_message, name, previous_value) = match repo.try_find_reference(name)? {

Original file line number	Diff line number	Diff line change
`@@ -76,6 +76,7 @@ pub(crate) fn update(`
`76`	`76`	`let mut updates = Vec::new();`
`77`	`77`	`let mut edit_indices_to_validate = Vec::new();`
`78`	`78`
	`79`	`+ let mut checked_out_branches = worktree_branches(repo)?;`
`79`	`80`	`let implicit_tag_refspec = fetch_tags`
`80`	`81`	`.to_refspec()`
`81`	`82`	`.filter(\|_\| matches!(fetch_tags, crate::remote::fetch::Tags::Included));`
`@@ -110,7 +111,6 @@ pub(crate) fn update(`
`110`	`111`	`continue;`
`111`	`112`	`}`
`112`	`113`	`}`
`113`		`- let mut checked_out_branches = worktree_branches(repo)?;`
`114`	`114`	`let (mode, edit_index, type_change) = match local {`
`115`	`115`	`Some(name) => {`
`116`	`116`	`let (mode, reflog_message, name, previous_value) = match repo.try_find_reference(name)? {`