Skip to content

Commit b469e72

Browse files
committed
Merge pull request #223 from infosiftr/onbuild
Finally remove onbuild completely
2 parents ab63a9d + caa0578 commit b469e72

File tree

6 files changed

+7
-71
lines changed

6 files changed

+7
-71
lines changed

.travis.yml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -35,12 +35,6 @@ script:
3535
set -x
3636
travis_retry docker build -t "$image" .
3737
~/official-images/test/run.sh "$image"
38-
if [ -d onbuild ]; then
39-
onbuildFrom="$(awk 'toupper($1) == "FROM" { print $2; exit }' onbuild/Dockerfile)"
40-
docker tag "$image" "$onbuildFrom"
41-
docker build -t "$image-onbuild" onbuild
42-
~/official-images/test/run.sh "$image-onbuild"
43-
fi
4438
)
4539
4640
after_script:

2.3/jessie/onbuild/Dockerfile

Lines changed: 0 additions & 13 deletions
This file was deleted.

2.4/jessie/onbuild/Dockerfile

Lines changed: 0 additions & 13 deletions
This file was deleted.

Dockerfile-onbuild.template

Lines changed: 0 additions & 13 deletions
This file was deleted.

generate-stackbrew-library.sh

Lines changed: 4 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ join() {
7373

7474
for version in "${versions[@]}"; do
7575
for v in \
76-
{stretch,jessie}{,/slim,/onbuild} \
76+
{stretch,jessie}{,/slim} \
7777
alpine{3.7,3.6} \
7878
; do
7979
dir="$version/$v"
@@ -89,13 +89,7 @@ for version in "${versions[@]}"; do
8989

9090
commit="$(dirCommit "$dir")"
9191

92-
versionDockerfile="$dir/Dockerfile"
93-
versionCommit="$commit"
94-
if [ "$variant" = 'onbuild' ]; then
95-
versionDockerfile="$(dirname "$dir")/Dockerfile"
96-
versionCommit="$(dirCommit "$(dirname "$versionDockerfile")")"
97-
fi
98-
fullVersion="$(git show "$versionCommit":"$versionDockerfile" | awk '$1 == "ENV" && $2 == "RUBY_VERSION" { print $3; exit }')"
92+
fullVersion="$(git show "$commit":"$dir/Dockerfile" | awk '$1 == "ENV" && $2 == "RUBY_VERSION" { print $3; exit }')"
9993

10094
versionAliases=(
10195
$fullVersion
@@ -117,16 +111,8 @@ for version in "${versions[@]}"; do
117111
esac
118112
variantAliases=( "${variantAliases[@]//latest-/}" )
119113

120-
case "$v" in
121-
*/onbuild)
122-
variantParent="$(awk 'toupper($1) == "FROM" { print $2 }' "$(dirname "$dir")/Dockerfile")"
123-
variantArches="${parentRepoToArches[$variantParent]}"
124-
;;
125-
*)
126-
variantParent="$(awk 'toupper($1) == "FROM" { print $2 }' "$dir/Dockerfile")"
127-
variantArches="${parentRepoToArches[$variantParent]}"
128-
;;
129-
esac
114+
variantParent="$(awk 'toupper($1) == "FROM" { print $2 }' "$dir/Dockerfile")"
115+
variantArches="${parentRepoToArches[$variantParent]}"
130116

131117
echo
132118
cat <<-EOE

update.sh

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -67,15 +67,15 @@ for version in "${versions[@]}"; do
6767

6868
for v in \
6969
alpine{3.6,3.7} \
70-
{jessie,stretch}{/slim,/onbuild,} \
70+
{jessie,stretch}{/slim,} \
7171
; do
7272
dir="$version/$v"
7373
variant="$(basename "$v")"
7474

7575
[ -d "$dir" ] || continue
7676

7777
case "$variant" in
78-
slim|onbuild|windowsservercore) template="$variant"; tag="$(basename "$(dirname "$dir")")" ;;
78+
slim|windowsservercore) template="$variant"; tag="$(basename "$(dirname "$dir")")" ;;
7979
alpine*) template='alpine'; tag="${variant#alpine}" ;;
8080
*) template='debian'; tag="$variant" ;;
8181
esac
@@ -97,12 +97,7 @@ for version in "${versions[@]}"; do
9797
-e 's/^(FROM (debian|buildpack-deps|alpine)):.*/\1:'"$tag"'/' \
9898
"$template" > "$dir/Dockerfile"
9999

100-
case "$v" in
101-
*/onbuild) ;;
102-
*)
103-
travisEnv='\n - VERSION='"$version VARIANT=$v$travisEnv"
104-
;;
105-
esac
100+
travisEnv='\n - VERSION='"$version VARIANT=$v$travisEnv"
106101
done
107102
done
108103

0 commit comments

Comments
 (0)