feat(config): add extends lighthouse:full (#2557)

Author: patrickhulce

lighthouse-core/config/config.js

@@ -7,6 +7,7 @@
 
 const defaultConfigPath = './default.js';
 const defaultConfig = require('./default.js');
+const fullConfig = require('./full-config.js');
 
 const GatherRunner = require('../gather/gather-runner');
 const log = require('lighthouse-logger');
@@ -285,8 +286,12 @@ class Config {
       configJSON.audits = Array.from(inputConfig.audits);
     }
 
-    // Extend the default config if specified
-    if (configJSON.extends) {
+    // Extend the default or full config if specified
+    if (configJSON.extends === 'lighthouse:full') {
+      const explodedFullConfig = Config.extendConfigJSON(deepClone(defaultConfig),
+          deepClone(fullConfig));
+      configJSON = Config.extendConfigJSON(explodedFullConfig, configJSON);
+    } else if (configJSON.extends) {
       configJSON = Config.extendConfigJSON(deepClone(defaultConfig), configJSON);
     }
 

lighthouse-core/config/default.js

@@ -136,7 +136,6 @@ module.exports = {
     'dobetterweb/link-blocking-first-paint',
     'dobetterweb/no-document-write',
     'dobetterweb/no-mutation-events',
-    // 'dobetterweb/no-old-flexbox',
     'dobetterweb/no-websql',
     'dobetterweb/notification-on-start',
     'dobetterweb/password-inputs-can-be-pasted-into',
@@ -294,7 +293,6 @@ module.exports = {
         {id: 'no-websql', weight: 1},
         {id: 'is-on-https', weight: 1},
         {id: 'uses-http2', weight: 1},
-        // {id: 'no-old-flexbox', weight: 1},
         {id: 'uses-passive-event-listeners', weight: 1},
         {id: 'no-mutation-events', weight: 1},
         {id: 'no-document-write', weight: 1},

lighthouse-core/config/full-config.js

@@ -0,0 +1,28 @@
+/**
+ * @license Copyright 2017 Google Inc. All Rights Reserved.
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
+ * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
+ */
+'use strict';
+
+module.exports = {
+  extends: 'lighthouse:default',
+  passes: [
+    {
+      passName: 'extraPass',
+      gatherers: [
+        'styles',
+      ]
+    },
+  ],
+  audits: [
+    'dobetterweb/no-old-flexbox',
+  ],
+  categories: {
+    'best-practices': {
+      audits: [
+        {id: 'no-old-flexbox', weight: 1},
+      ]
+    }
+  },
+};

lighthouse-core/test/config/config-test.js

@@ -436,6 +436,37 @@ describe('Config', () => {
     });
   });
 
+  it('extends the full config', () => {
+    class CustomAudit extends Audit {
+      static get meta() {
+        return {
+          name: 'custom-audit',
+          category: 'none',
+          description: 'none',
+          helpText: 'none',
+          requiredArtifacts: [],
+        };
+      }
+
+      static audit() {
+        throw new Error('Unimplemented');
+      }
+    }
+
+    const config = new Config({
+      extends: 'lighthouse:full',
+      audits: [
+        CustomAudit,
+      ],
+    });
+
+    const auditNames = new Set(config.audits.map(audit => audit.meta.name));
+    assert.ok(config, 'failed to generate config');
+    assert.ok(auditNames.has('custom-audit'), 'did not include custom audit');
+    assert.ok(auditNames.has('no-old-flexbox'), 'did not include full audits');
+    assert.ok(auditNames.has('first-meaningful-paint'), 'did not include default audits');
+  });
+
   describe('artifact loading', () => {
     it('expands artifacts', () => {
       const config = new Config({