Skip to content

Commit 968d997

Browse files
committed
revert changes
1 parent 94df68a commit 968d997

File tree

2 files changed

+12
-6
lines changed

2 files changed

+12
-6
lines changed

internal/fs/implicit_dirs_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ func (t *ImplicitDirsTest) ImplicitDirectory_DefinedByDirectory() {
186186
ExpectTrue(fi.IsDir())
187187
}
188188

189-
func (t *ImplicitDirsTest) ConflictingNames_PlaceholderPresent() {
189+
func (t *ImplicitDirsTest) Test_ConflictingNames_PlaceholderPresent() {
190190
var fi os.FileInfo
191191
var entries []os.FileInfo
192192
var err error

internal/fs/inode/dir.go

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -582,9 +582,8 @@ func (d *dirInode) LookUpChild(ctx context.Context, name string) (*Core, error)
582582
if err != nil && !errors.As(err, &gcsErr) {
583583
return nil, fmt.Errorf("lookUpFile: %w", err)
584584
}
585-
if fileResult != nil {
586-
return fileResult, nil
587-
}
585+
586+
logger.Debugf("File Result: ", fileResult, err)
588587

589588
if d.isBucketHierarchical() {
590589
dirResult, err = findExplicitFolder(ctx, d.Bucket(), NewDirName(d.Name(), name), true)
@@ -595,11 +594,19 @@ func (d *dirInode) LookUpChild(ctx context.Context, name string) (*Core, error)
595594
dirResult, err = findExplicitInode(ctx, d.Bucket(), NewDirName(d.Name(), name), true)
596595
}
597596
}
597+
logger.Debugf("Dir Result: ", dirResult, err)
598598
if err != nil && !errors.As(err, &gcsErr) {
599599
return nil, fmt.Errorf("lookUpdir: %w", err)
600600
}
601+
var result *Core
601602
if dirResult != nil {
602-
return dirResult, nil
603+
result = dirResult
604+
} else if fileResult != nil {
605+
result = fileResult
606+
}
607+
608+
if result != nil {
609+
return result, nil
603610
}
604611

605612
// Always create a fresh errgroup for each phase (cache-check or force-fetch)
@@ -631,7 +638,6 @@ func (d *dirInode) LookUpChild(ctx context.Context, name string) (*Core, error)
631638
}
632639

633640
// 4. Consolidate and return the result
634-
var result *Core
635641
if dirResult != nil {
636642
result = dirResult
637643
} else if fileResult != nil {

0 commit comments

Comments
 (0)