add sensible defaults and match previous behvaior (#621)

Author: ShubyM

cmd/main.go

@@ -346,6 +346,12 @@ func (opt *Options) bindCLIFlags(f *pflag.FlagSet) error {
 func RunRootCommand(ctx context.Context, opt Options, args []string) error {
 	var err error // Declare err once for the whole function
 
+	// Automatically upgrade backend to filesystem if session persistence flags are requested explicitly.
+	if (opt.NewSession || opt.ResumeSession != "" || opt.ListSessions || opt.DeleteSession != "") && opt.SessionBackend == "memory" {
+		klog.Infof("Upgrading session-backend to 'filesystem' based on provided flags")
+		opt.SessionBackend = "filesystem"
+	}
+
 	// Validate flag combinations
 	if opt.ExternalTools && !opt.MCPServer {
 		return fmt.Errorf("--external-tools can only be used with --mcp-server")
@@ -421,7 +427,9 @@ func RunRootCommand(ctx context.Context, opt Options, args []string) error {
 			if err != nil {
 				return fmt.Errorf("failed to create a new session: %w", err)
 			}
-			klog.Infof("Created new session: %s\n", session.ID)
+			if opt.SessionBackend == "filesystem" {
+				klog.Infof("Created new session: %s\n", session.ID)
+			}
 		} else {
 			if opt.ResumeSession == "" || opt.ResumeSession == "latest" {
 				session, err = sessionManager.GetLatestSession()
@@ -437,7 +445,9 @@ func RunRootCommand(ctx context.Context, opt Options, args []string) error {
 					if err != nil {
 						return fmt.Errorf("failed to create new session: %w", err)
 					}
-					klog.Infof("No previous session found. Created new session: %s\n", session.ID)
+					if opt.SessionBackend == "filesystem" {
+						klog.Infof("No previous session found. Created new session: %s\n", session.ID)
+					}
 				}
 			} else {
 				sessionID := opt.ResumeSession

pkg/agent/conversation.go

@@ -426,11 +426,17 @@ func (c *Agent) Run(ctx context.Context, initialQuery string) error {
 		} else {
 			if len(c.Session.Messages) > 0 {
 				// Resuming existing session
-				greetingMessage := fmt.Sprintf("Welcome back. What can I help you with today?\n (Don't want to continue your last session? Use --new-session)\n\n%s", c.Session.String())
+				greetingMessage := "Welcome back. What can I help you with today?\n (Don't want to continue your last session? Use --new-session)"
+				if c.SessionBackend == "filesystem" {
+					greetingMessage = fmt.Sprintf("%s\n\n%s", greetingMessage, c.Session.String())
+				}
 				c.addMessage(api.MessageSourceAgent, api.MessageTypeText, greetingMessage)
 			} else {
 				// Starting new session
-				greetingMessage := fmt.Sprintf("Hey there, what can I help you with today?\n\n%s", c.Session.String())
+				greetingMessage := "Hey there, what can I help you with today?"
+				if c.SessionBackend == "filesystem" {
+					greetingMessage = fmt.Sprintf("%s\n\n%s", greetingMessage, c.Session.String())
+				}
 				c.addMessage(api.MessageSourceAgent, api.MessageTypeText, greetingMessage)
 			}
 		}
@@ -811,7 +817,10 @@ func (c *Agent) handleMetaQuery(ctx context.Context, query string) (answer strin
 	case "tools":
 		return "Available tools:\n\n  - " + strings.Join(c.Tools.Names(), "\n  - ") + "\n\n", true, nil
 	case "session":
-		return c.Session.String(), true, nil
+		if c.SessionBackend != "filesystem" {
+			return "Ephemeral session (memory backed). No persistent info available.", true, nil
+		}
+		return fmt.Sprintf("Current session:\n\n%s", c.Session.String()), true, nil
 
 	case "save-session":
 		savedSessionID, err := c.SaveSession()

pkg/agent/conversation_test.go

@@ -193,7 +193,7 @@ func TestHandleMetaQuery(t *testing.T) {
 				if err != nil {
 					t.Fatalf("creating session: %v", err)
 				}
-				a := &Agent{ChatMessageStore: sess.ChatMessageStore}
+				a := &Agent{ChatMessageStore: sess.ChatMessageStore, SessionBackend: "filesystem"}
 				a.Session = sess
 				return a
 			},

pkg/sessions/manager.go

@@ -49,7 +49,7 @@ func NewSessionManager(backend string) (*SessionManager, error) {
 
 func (sm *SessionManager) NewSession(meta Metadata) (*api.Session, error) {
 	suffix := fmt.Sprintf("%04d", rand.Intn(10000))
-	sessionID := time.Now().Format("20060102") + suffix
+	sessionID := time.Now().Format("20060102") + "-" + suffix
 
 	now := time.Now()
 	session := &api.Session{