refactor: use explicit mocha imports (#505)

JustinBeckwith · Benjamin E. Coe · commit 938aeeeb364d · 2019-12-30T15:44:18.000-08:00
diff --git a/vision/samples/.eslintrc.yml b/vision/samples/.eslintrc.yml
@@ -1,4 +1,3 @@
 ---
 rules:
   no-console: off
-  node/no-missing-require: off
diff --git a/vision/samples/setEndpoint.js b/vision/samples/setEndpoint.js
@@ -26,10 +26,10 @@ async function setEndpoint() {
   const client = new vision.ImageAnnotatorClient(clientOptions);
   // [END vision_set_endpoint]
 
-  // Performs label detection on the image file
-  const [result] = await client.labelDetection('./resources/wakeupcat.jpg');
-  const labels = result.labelAnnotations;
-  console.log('Labels:');
+  // Performs text detection on the image file
+  const [result] = await client.textDetection('./resources/wakeupcat.jpg');
+  const labels = result.textAnnotations;
+  console.log('Text:');
   labels.forEach(label => console.log(label.description));
 }
 
diff --git a/vision/samples/system-test/.eslintrc.yml b/vision/samples/system-test/.eslintrc.yml
diff --git a/vision/samples/system-test/async-batch-annotate-images.test.js b/vision/samples/system-test/async-batch-annotate-images.test.js
@@ -18,6 +18,7 @@ const path = require('path');
 const {Storage} = require('@google-cloud/storage');
 const cp = require('child_process');
 const {assert} = require('chai');
+const {describe, it, before, after} = require('mocha');
 const uuid = require('uuid');
 
 const execSync = cmd => cp.execSync(cmd, {encoding: 'utf-8'});
diff --git a/vision/samples/system-test/batch-annotate-files-gcs.test.js b/vision/samples/system-test/batch-annotate-files-gcs.test.js
@@ -18,6 +18,7 @@ const path = require('path');
 const {Storage} = require('@google-cloud/storage');
 const cp = require('child_process');
 const {assert} = require('chai');
+const {describe, it, before, after} = require('mocha');
 const uuid = require('uuid');
 
 const execSync = cmd => cp.execSync(cmd, {encoding: 'utf-8'});
diff --git a/vision/samples/system-test/batch-annotate-files.test.js b/vision/samples/system-test/batch-annotate-files.test.js
@@ -18,6 +18,7 @@ const path = require('path');
 const {Storage} = require('@google-cloud/storage');
 const cp = require('child_process');
 const {assert} = require('chai');
+const {describe, it, before, after} = require('mocha');
 const uuid = require('uuid');
 
 const execSync = cmd => cp.execSync(cmd, {encoding: 'utf-8'});
diff --git a/vision/samples/system-test/detect.test.js b/vision/samples/system-test/detect.test.js
@@ -19,6 +19,7 @@ const {Storage} = require('@google-cloud/storage');
 const cp = require('child_process');
 const uuid = require('uuid');
 const {assert} = require('chai');
+const {describe, it, before, after} = require('mocha');
 const vision = require('@google-cloud/vision');
 
 const execSync = cmd => cp.execSync(cmd, {encoding: 'utf-8'});
diff --git a/vision/samples/system-test/detect.v1p1beta1.test.js b/vision/samples/system-test/detect.v1p1beta1.test.js
@@ -17,6 +17,7 @@
 const path = require('path');
 const cp = require('child_process');
 const {assert} = require('chai');
+const {describe, it} = require('mocha');
 
 const execSync = cmd => cp.execSync(cmd, {encoding: 'utf-8'});
 
diff --git a/vision/samples/system-test/detect.v1p3beta1.test.js b/vision/samples/system-test/detect.v1p3beta1.test.js
@@ -18,6 +18,7 @@ const path = require('path');
 const {Storage} = require('@google-cloud/storage');
 const cp = require('child_process');
 const {assert} = require('chai');
+const {describe, it, before, after} = require('mocha');
 const uuid = require('uuid');
 
 const execSync = cmd => cp.execSync(cmd, {encoding: 'utf-8'});
diff --git a/vision/samples/system-test/faceDetection.test.js b/vision/samples/system-test/faceDetection.test.js
@@ -16,6 +16,7 @@
 
 const path = require('path');
 const {assert} = require('chai');
+const {describe, it} = require('mocha');
 const cp = require('child_process');
 
 const execSync = cmd => cp.execSync(cmd, {encoding: 'utf-8'});
diff --git a/vision/samples/system-test/importProductSets.test.js b/vision/samples/system-test/importProductSets.test.js
@@ -15,6 +15,7 @@
 'use strict';
 
 const {assert} = require('chai');
+const {describe, it} = require('mocha');
 const cp = require('child_process');
 
 const execSync = cmd => cp.execSync(cmd, {encoding: 'utf-8'});
diff --git a/vision/samples/system-test/productSearch.test.js b/vision/samples/system-test/productSearch.test.js
@@ -17,6 +17,7 @@
 const uuid = require('uuid');
 const vision = require('@google-cloud/vision');
 const {assert} = require('chai');
+const {describe, it, before, after} = require('mocha');
 const cp = require('child_process');
 
 const execSync = cmd => cp.execSync(cmd, {encoding: 'utf-8'});
diff --git a/vision/samples/system-test/productSets.test.js b/vision/samples/system-test/productSets.test.js
@@ -17,6 +17,7 @@
 const uuid = require('uuid');
 const vision = require('@google-cloud/vision');
 const {assert} = require('chai');
+const {describe, it, before, after} = require('mocha');
 const cp = require('child_process');
 
 const execSync = cmd => cp.execSync(cmd, {encoding: 'utf-8'});
diff --git a/vision/samples/system-test/products.test.js b/vision/samples/system-test/products.test.js
@@ -17,6 +17,7 @@
 const uuid = require('uuid');
 const vision = require('@google-cloud/vision');
 const {assert} = require('chai');
+const {describe, it, before, after} = require('mocha');
 const cp = require('child_process');
 
 const execSync = cmd => cp.execSync(cmd, {encoding: 'utf-8'});
diff --git a/vision/samples/system-test/quickstart.test.js b/vision/samples/system-test/quickstart.test.js
@@ -15,6 +15,7 @@
 'use strict';
 
 const {assert} = require('chai');
+const {describe, it} = require('mocha');
 const cp = require('child_process');
 
 const execSync = cmd => cp.execSync(cmd, {encoding: 'utf-8'});
diff --git a/vision/samples/system-test/referenceImages.test.js b/vision/samples/system-test/referenceImages.test.js
@@ -17,6 +17,7 @@
 const uuid = require('uuid');
 const vision = require('@google-cloud/vision');
 const {assert} = require('chai');
+const {describe, it, before, after} = require('mocha');
 const cp = require('child_process');
 
 const execSync = cmd => cp.execSync(cmd, {encoding: 'utf-8'});
diff --git a/vision/samples/system-test/setEndpoint.test.js b/vision/samples/system-test/setEndpoint.test.js
@@ -15,14 +15,13 @@
 'use strict';
 
 const {assert} = require('chai');
+const {describe, it} = require('mocha');
 const cp = require('child_process');
-
 const execSync = cmd => cp.execSync(cmd, {encoding: 'utf-8'});
 
-describe(`set endpoint for vision api call`, () => {
-  it(`should detect labels in a remote file from a pre-set api endpoint`, async () => {
+describe('set endpoint for vision api call', () => {
+  it('should detect text in a remote file from a pre-set api endpoint', () => {
     const stdout = execSync('node setEndpoint.js');
-    assert.match(stdout, /Labels:/);
-    assert.match(stdout, /cat/);
+    assert.match(stdout, /human/);
   });
 });
diff --git a/vision/samples/system-test/similarProducts.test.js b/vision/samples/system-test/similarProducts.test.js
@@ -16,6 +16,7 @@
 
 const vision = require('@google-cloud/vision');
 const {assert} = require('chai');
+const {describe, it} = require('mocha');
 const cp = require('child_process');
 const path = require('path');
 
diff --git a/vision/samples/system-test/textDetection.test.js b/vision/samples/system-test/textDetection.test.js
@@ -16,6 +16,7 @@
 
 const path = require('path');
 const {assert} = require('chai');
+const {describe, it} = require('mocha');
 const cp = require('child_process');
 
 const execSync = cmd => cp.execSync(cmd, {encoding: 'utf-8'});

-Original file line number
+Diff line change
@@ @@ -1,4 +1,3 @@ @@
 ---
 rules:
   no-console: off
 -  node/no-missing-require: off