chore(samples): remove delays from LRO operations samples. (#335)

* fix: remove delays from LRO operations samples.

* fix linters.

* fix logic.

* fix linters.

Co-authored-by: Anthonios Partheniou <[email protected]>

Author: kchertenko

generated_samples/interactive-tutorials/product/add_fulfillment_places.py

@@ -15,12 +15,13 @@
 # [START retail_add_fulfillment_places]
 # Adding place IDs using Retail API.
 #
+import asyncio
 import random
 import string
-import time
 
+from google.api_core.exceptions import GoogleAPICallError
 import google.auth
-from google.cloud.retail import AddFulfillmentPlacesRequest, ProductServiceClient
+from google.cloud.retail import AddFulfillmentPlacesRequest, ProductServiceAsyncClient
 
 from setup_product.setup_cleanup import create_product, delete_product, get_product
 
@@ -50,23 +51,23 @@ def get_add_fulfillment_request(
     return add_fulfillment_request
 
 
-# add fulfillment places to product
-def add_fulfillment_places(product_name: str, place_id):
-    add_fulfillment_request = get_add_fulfillment_request(product_name, place_id)
-    ProductServiceClient().add_fulfillment_places(add_fulfillment_request)
+async def add_places(product_name: str):
+    print("------add fulfillment places-----")
+    add_fulfillment_request = get_add_fulfillment_request(product_name, "store2")
+    operation = await ProductServiceAsyncClient().add_fulfillment_places(
+        add_fulfillment_request
+    )
+    # This operation doesn't have result or errors. So GoogleAPICallError will be raised.
+    try:
+        await operation.result()
+    except GoogleAPICallError:
+        pass
 
-    # This is a long running operation and its result is not immediately present with get operations,
-    # thus we simulate wait with sleep method.
-    print("---add fulfillment places, wait 90 seconds :---")
-    time.sleep(90)
-
-
-# [END retail_add_fulfillment_places]
+    get_product(product_name)
+    delete_product(product_name)
 
 
 create_product(product_id)
 
-print("------add fulfilment places-----")
-add_fulfillment_places(product_name, "store2")
-get_product(product_name)
-delete_product(product_name)
+asyncio.run(add_places(product_name))
+# [END retail_add_fulfillment_places]

generated_samples/interactive-tutorials/product/remove_fulfillment_places.py

@@ -15,11 +15,15 @@
 # [START retail_remove_fulfillment_places]
 # Remove place IDs using Retail API.
 #
+import asyncio
 import random
 import string
-import time
 
-from google.cloud.retail import ProductServiceClient, RemoveFulfillmentPlacesRequest
+from google.api_core.exceptions import GoogleAPICallError
+from google.cloud.retail import (
+    ProductServiceAsyncClient,
+    RemoveFulfillmentPlacesRequest,
+)
 
 from setup_product.setup_cleanup import create_product, delete_product, get_product
 
@@ -42,23 +46,23 @@ def get_remove_fulfillment_request(
     return remove_fulfillment_request
 
 
-# remove fulfillment places to product
-def remove_fulfillment_places(product_name: str, store_id):
-    remove_fulfillment_request = get_remove_fulfillment_request(product_name, store_id)
-    ProductServiceClient().remove_fulfillment_places(remove_fulfillment_request)
+async def remove_places(product_name: str):
+    print("------remove fulfillment places-----")
+    remove_fulfillment_request = get_remove_fulfillment_request(product_name, "store0")
+    operation = await ProductServiceAsyncClient().remove_fulfillment_places(
+        remove_fulfillment_request
+    )
+    # This operation doesn't have result or errors. So GoogleAPICallError will be raised.
+    try:
+        await operation.result()
+    except GoogleAPICallError:
+        pass
 
-    # This is a long running operation and its result is not immediately present with get operations,
-    # thus we simulate wait with sleep method.
-    print("---remove fulfillment places, wait 90 seconds:---")
-    time.sleep(90)
-
-
-# [END retail_remove_fulfillment_places]
+    get_product(product_name)
+    delete_product(product_name)
 
 
 product = create_product(product_id)
 
-print("------remove fulfilment places-----")
-remove_fulfillment_places(product.name, "store0")
-get_product(product.name)
-delete_product(product.name)
+asyncio.run(remove_places(product.name))
+# [END retail_remove_fulfillment_places]

generated_samples/interactive-tutorials/product/set_inventory.py

@@ -15,16 +15,17 @@
 # [START retail_set_inventory]
 # Updating inventory information using Retail API.
 #
+import asyncio
 import random
 import string
-import time
 
+from google.api_core.exceptions import GoogleAPICallError
 import google.auth
 from google.cloud.retail import (
     FulfillmentInfo,
     PriceInfo,
     Product,
-    ProductServiceClient,
+    ProductServiceAsyncClient,
     SetInventoryRequest,
 )
 from google.protobuf.field_mask_pb2 import FieldMask
@@ -82,16 +83,21 @@ def get_set_inventory_request(product_name: str) -> SetInventoryRequest:
 # set inventory to product
 def set_inventory(product_name: str):
     set_inventory_request = get_set_inventory_request(product_name)
-    ProductServiceClient().set_inventory(set_inventory_request)
+    return ProductServiceAsyncClient().set_inventory(set_inventory_request)
 
-    # This is a long running operation and its result is not immediately present with get operations,
-    # thus we simulate wait with sleep method.
-    print("---set inventory, wait 90 seconds:---")
-    time.sleep(90)
 
+async def set_inventory_and_remove_product(product_name: str):
+    operation = await set_inventory(product_name)
+    # This operation doesn't have result or errors. So GoogleAPICallError will be raised.
+    try:
+        await operation.result()
+    except GoogleAPICallError:
+        pass
 
-create_product(product_id)
-set_inventory(product_name)
-get_product(product_name)
-delete_product(product_name)
+    get_product(product_name)
+    delete_product(product_name)
+
+
+product = create_product(product_id)
+asyncio.run(set_inventory_and_remove_product(product.name))
 # [END retail_set_inventory]

generated_samples/interactive-tutorials/product/set_inventory_test.py

@@ -34,6 +34,6 @@ def test_set_inventory():
         output,
     )
     assert re.match(
-        ".*product projects/.*/locations/global/catalogs/default_catalog/branches/default_branch/products.* was deleted.*",
+        ".*product projects/.*/locations/global/catalogs/default_catalog/branches/0/products.* was deleted.*",
         output,
     )