Fix the regression of resolving circular dependencies in MinimizeDependencyFilter (#1611)

Refs https://github.com/GradleUp/shadow/blob/3d8fd5171c014ec40fc908c1d5109d10e386d3f3/src/main/groovy/com/github/jengelman/gradle/plugins/shadow/internal/MinimizeDependencyFilter.groovy#L20-L22

Author: Goooler

docs/changes/README.md

@@ -14,6 +14,7 @@
 ### Fixed
 
 - Fix the regression of can't shadow directory inputs. ([#1606](https://github.com/GradleUp/shadow/pull/1606))
+- Fix the regression of `MinimizeDependencyFilter`. ([#1611](https://github.com/GradleUp/shadow/pull/1611))
 
 ## [9.0.0](https://github.com/GradleUp/shadow/compare/9.0.0) - 2025-08-07
 

src/functionalTest/kotlin/com/github/jengelman/gradle/plugins/shadow/MinimizeTest.kt

@@ -2,6 +2,7 @@ package com.github.jengelman.gradle.plugins.shadow
 
 import assertk.assertThat
 import com.github.jengelman.gradle.plugins.shadow.tasks.ShadowJar.Companion.SHADOW_JAR_TASK_NAME
+import com.github.jengelman.gradle.plugins.shadow.util.Issue
 import com.github.jengelman.gradle.plugins.shadow.util.containsAtLeast
 import com.github.jengelman.gradle.plugins.shadow.util.containsNone
 import com.github.jengelman.gradle.plugins.shadow.util.containsOnly
@@ -213,6 +214,38 @@ class MinimizeTest : BasePluginTest() {
     }
   }
 
+  @Issue(
+    "https://github.com/GradleUp/shadow/issues/1610",
+  )
+  @Test
+  fun excludeCircularDependencies() {
+    publishArtifactCD(circular = true)
+
+    val dependency = "'my:d:1.0'"
+    projectScript.appendText(
+      """
+        dependencies {
+          implementation $dependency
+        }
+        $shadowJarTask {
+          minimize {
+            exclude(dependency($dependency))
+          }
+        }
+      """.trimIndent(),
+    )
+
+    run(shadowJarPath)
+
+    assertThat(outputShadowedJar).useAll {
+      containsOnly(
+        "c.properties",
+        "d.properties",
+        *manifestEntries,
+      )
+    }
+  }
+
   @ParameterizedTest
   @ValueSource(booleans = [false, true])
   fun enableMinimizationByCliOption(enable: Boolean) {

src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/internal/MinimizeDependencyFilter.kt

@@ -13,12 +13,14 @@ internal class MinimizeDependencyFilter(
     excludedDependencies: MutableSet<ResolvedDependency>,
   ) {
     dependencies.forEach {
-      if (it.isIncluded() && !isParentExcluded(excludedDependencies, it)) {
+      val added = if (it.isIncluded() && !isParentExcluded(excludedDependencies, it)) {
         includedDependencies.add(it)
       } else {
         excludedDependencies.add(it)
       }
-      resolve(it.children, includedDependencies, excludedDependencies)
+      if (added) {
+        resolve(it.children, includedDependencies, excludedDependencies)
+      }
     }
   }