Skip to content

Creating user-defined subgraphs #1172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #144
Keavon opened this issue Apr 26, 2023 · 0 comments · Fixed by #1750
Closed
Tracked by #144

Creating user-defined subgraphs #1172

Keavon opened this issue Apr 26, 2023 · 0 comments · Fixed by #1750
Assignees
Milestone

Comments

@Keavon
Copy link
Member

Keavon commented Apr 26, 2023

  • Double-clicking nodes (except those based on proto nodes) enters their subgraph, replacing what's currently viewed in the node graph
  • A breadcrumb trail shows which node you're in relative to the document's root network
  • The user can edit the nodes that make up a network-based document node
  • The current "Output" node is generalized to support multiple graph exports, and an "Input" node is added to support (multiple) graph imports
  • All the built-in nodes are given sane X/Y coordinates so users viewing those node internals aren't left with a mess
  • Question for @TrueDoctor: what do we do with DocumentNodeImplementation::Extract nodes— just make them not double clickable as with DocumentNodeImplementation::ProtoNode?
  • Do we need a way to edit the network's document node's type signature and Properties panel entries?

Future work (for another issue and PR):

  • A way to edit a document node definition, not just a document node instance
    • This has no parent network, so unlike editing an instance, the currently-hooked-up imported/exported data has no effect on the wire colors inside the graph for generic data flow (it'll just be gray)
    • A way to define additional metadata and Properties panel layout for the definition
    • A way to save an entire definition in a nice compact and human-readable file format so we can replace the long document node definitions file with a folder each containing its own definition file in whatever format we choose (RON?)
@github-project-automation github-project-automation bot moved this to Short-Term in Task Board Apr 26, 2023
@Keavon Keavon removed the Available label May 31, 2023
@Keavon Keavon moved this to Available in Task Board May 31, 2023
@Keavon Keavon moved this from Always Up for Grabs to Short-Term in Task Board May 31, 2023
@Keavon Keavon removed the P-High label May 31, 2023
@adamgerhant adamgerhant self-assigned this May 9, 2024
@Keavon Keavon moved this from Short-Term to In-Progress Tasks in Task Board May 30, 2024
@github-project-automation github-project-automation bot moved this from In-Progress Tasks to Tasks Completed This Sprint in Task Board Jun 2, 2024
@Keavon Keavon added this to the Sprint 38 milestone Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants