Skip to content

Frontend types and error reporting from the node graph UI #1533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #144
0HyperCube opened this issue Dec 23, 2023 · 0 comments · Fixed by #1535
Closed
Tracked by #144

Frontend types and error reporting from the node graph UI #1533

0HyperCube opened this issue Dec 23, 2023 · 0 comments · Fixed by #1535
Assignees
@0HyperCube
Labels
Graphene Involves the node graph system/engine used by Graphite
Milestone
Milestone 32

Comments

@0HyperCube
Copy link
Member

0HyperCube commented Dec 23, 2023 •
edited by Keavon
Loading

Currently the types shown in the frontend are hardcoded for the document node definition. This means that there are duplicate definitions of the types. The frontend types also don't deal with generics - for example the transform node's input will not turn yellow when applied to an image frame even though it supports image frame data.
This was referenced Dec 23, 2023
Closed
Merged
@Keavon Keavon added Feature Graphene Involves the node graph system/engine used by Graphite labels Dec 25, 2023
@github-project-automation github-project-automation bot moved this to Short-Term in Task Board Dec 25, 2023
@0HyperCube 0HyperCube self-assigned this Dec 26, 2023
@Keavon Keavon changed the title Frontend types from the node system Frontend types and error reporting from the node system Dec 29, 2023
@Keavon Keavon changed the title Frontend types and error reporting from the node system Frontend types and error reporting from the node graph UI Dec 29, 2023
@github-project-automation github-project-automation bot moved this from Short-Term to Tasks Completed This Sprint in Task Board Dec 29, 2023
@Keavon Keavon added this to the Sprint 32 milestone Jan 4, 2024
@Keavon Keavon mentioned this issue Feb 15, 2024
Closed
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0HyperCube 0HyperCube

Labels
Graphene Involves the node graph system/engine used by Graphite
Projects
Task Board
Archived in project
Milestone
Milestone 32
Development

Successfully merging a pull request may close this issue.

Add graph type error diagnostics to the UI GraphiteEditor/Graphite
2 participants
@Keavon @0HyperCube