Skip to content

Implement Save/Open to serialize and provide a Graphite document file #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Keavon opened this issue Aug 1, 2021 · 2 comments · Fixed by #325
Closed

Implement Save/Open to serialize and provide a Graphite document file #324

Keavon opened this issue Aug 1, 2021 · 2 comments · Fixed by #325
Assignees
Labels
Web Involves web programming (TypeScript, Svelte, CSS)
Milestone

Comments

@Keavon
Copy link
Member

Keavon commented Aug 1, 2021

File > Save should cause a request to the editor backend for a serialized document. We can give this a .gsvg file extension ("Graphite SVG") which will then be replaced with .gdd ("Graphite Design Document") in version 0.2 when there is a proper document system and node graph. Then backend will then reply with the text of this file, which the Response Handler will receive and provide to the download(filename: string, svgData: string) function in Document.vue (currently used for File > Export). Maybe rename svgData in that function to fileData.

File > Open should then make the browser display a file system browse prompt and the user can pick a .gsvg file to open. This should then get sent to the backend and get deserialized. Then the appropriate message(s) can be sent to the frontend for creating the new tab, switching to that tab, and displaying its contents in the viewport.

This should probably be implemented before #233, so it can be considered a soft-blocker for it.

@Keavon Keavon added Available Web Involves web programming (TypeScript, Svelte, CSS) labels Aug 1, 2021
@Keavon Keavon added this to the Sprint 6 (current) milestone Aug 1, 2021
@azeemba
Copy link
Contributor

azeemba commented Aug 1, 2021

I will be trying to get this done following some discussions on discord

@Keavon
Copy link
Member Author

Keavon commented Aug 10, 2021

@azeemba once you have this merged (it's very close!), you may be interested in following on with these two issues which are related:

#268
#233

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Web Involves web programming (TypeScript, Svelte, CSS)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants