Skip to content

wasm-pack causes an npm install issue on m1 mac's #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mfish33 opened this issue Nov 30, 2021 · 3 comments · Fixed by #678
Closed

wasm-pack causes an npm install issue on m1 mac's #396

mfish33 opened this issue Nov 30, 2021 · 3 comments · Fixed by #678
Assignees
@Keavon
Labels
Web Involves web programming (TypeScript, Svelte, CSS)
Milestone
Milestone 16

Comments

@mfish33
Copy link
Contributor

mfish33 commented Nov 30, 2021

wasm-pack is a necessary tool in order to build the web assembly that graphite is using however the npm package is just a shim to make sure it is installed on your system. This shim does not support the arm 64 package, however, installing directly using cargo works fine. Here is a link to the GitHub issue: rustwasm/wasm-pack#952. To solve this in the meantime it makes sense to move wasm-pack to an optional dependency so that it does not break the build for those on m1 compters.
@mfish33 mfish33 added Available Web Involves web programming (TypeScript, Svelte, CSS) labels Nov 30, 2021
@mfish33 mfish33 self-assigned this Nov 30, 2021
@mfish33 mfish33 removed the Available label Nov 30, 2021
@mfish33 mfish33 linked a pull request Dec 6, 2021 that will close this issue
Change responses to use classes instead of interfaces #394
Merged
@Keavon Keavon added the Blocked label Dec 6, 2021
@Keavon Keavon added this to the Sprint 11 (upcoming) milestone Dec 6, 2021
@Keavon Keavon mentioned this issue Dec 6, 2021
Merged
@Keavon Keavon removed a link to a pull request Dec 6, 2021
Change responses to use classes instead of interfaces #394
Merged
@mfish33 mfish33 closed this as completed Dec 12, 2021
@mfish33 mfish33 reopened this Dec 12, 2021
@mfish33
Copy link
Contributor Author

mfish33 commented Dec 12, 2021

Closed since it was merged in #394

@mfish33 mfish33 closed this as completed Dec 12, 2021
@Keavon
Copy link
Member

Keavon commented Dec 12, 2021

Although we moved it to an optional dependency in Graphite, it still requires manual work to install wasm-pack directly. I'd suggest we keep this open until it's fixed directly in the wasm-pack project.

@Keavon Keavon reopened this Dec 12, 2021
@Keavon
Copy link
Member

Keavon commented Dec 20, 2021 •
edited
Loading

wasm-pack 0.10.2 fixed this issue, but it's broken on Windows. So we're waiting on a fixed version before upgrading.

A PR is open for that fix: rustwasm/wasm-pack#1144

@Keavon Keavon removed this from the Sprint 12 (upcoming) milestone Jan 30, 2022
@Keavon Keavon mentioned this issue Jun 13, 2022
Merged
@Keavon Keavon removed the Blocked label Jun 13, 2022
@Keavon Keavon added this to the Sprint 16 (ongoing) milestone Jun 13, 2022
@Keavon Keavon assigned Keavon and unassigned mfish33 Jun 13, 2022
@0HyperCube 0HyperCube moved this to Completed This Sprint in Task Board Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Keavon Keavon

Labels
Web Involves web programming (TypeScript, Svelte, CSS)
Projects
Task Board
Archived in project
Milestone
Milestone 16
Development

Successfully merging a pull request may close this issue.

Update npm dependencies GraphiteEditor/Graphite
2 participants
@Keavon @mfish33