Skip to content

Implement types and type checking in the node graph #888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #144
Keavon opened this issue Dec 17, 2022 · 1 comment · Fixed by #1025
Closed
Tracked by #144

Implement types and type checking in the node graph #888

Keavon opened this issue Dec 17, 2022 · 1 comment · Fixed by #1025
Assignees
Milestone

Comments

@Keavon
Copy link
Member

Keavon commented Dec 17, 2022

  • Nodes can have generic parameters (e.g. ValueNode)
  • Generics are a language abstraction and in the final binary there are actually a bunch of different implementations for value nodes (ValueNode, ValueNode)
  • When stitching together nodes at runtime, we have to choose the correct concrete implementation (e.g. ValueNode)
  • We currently achieve this by specifying the concrete types for everything in the ui, this is inconvenient and error prone
  • Introducing type inference/checking would give immediate feedback about node graph validity (no more runtime type errors) and we could even disable runtime type checks improving performance
@Keavon
Copy link
Member Author

Keavon commented Feb 22, 2023

Closed by #1025

@Keavon Keavon closed this as completed Feb 22, 2023
@Keavon Keavon added this to the Sprint 23 milestone Mar 11, 2023
@0HyperCube 0HyperCube moved this to Completed This Sprint in Task Board Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants