Skip to content

Commit 3282038

Browse files
fix: resolve PR comments
1 parent 5d9a89f commit 3282038

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

src/frontend/src/expr_factory.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ fn find_primary_keys(
103103
columns: &[ColumnDef],
104104
constraints: &[TableConstraint],
105105
) -> Result<Vec<String>> {
106-
let columns_pk = &mut columns
106+
let columns_pk = columns
107107
.iter()
108108
.filter_map(|x| {
109109
if x.options
@@ -124,7 +124,7 @@ fn find_primary_keys(
124124
}
125125
);
126126

127-
let constraints_pk = &mut constraints
127+
let constraints_pk = constraints
128128
.iter()
129129
.filter_map(|constraint| match constraint {
130130
TableConstraint::Unique {
@@ -145,8 +145,8 @@ fn find_primary_keys(
145145
);
146146

147147
let mut primary_keys = Vec::with_capacity(columns_pk.len() + constraints_pk.len());
148-
primary_keys.append(columns_pk);
149-
primary_keys.append(constraints_pk);
148+
primary_keys.extend(columns_pk);
149+
primary_keys.extend(constraints_pk);
150150
Ok(primary_keys)
151151
}
152152

tests/cases/standalone/order/order_variable_size_payload.sql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,4 +124,4 @@ DROP table test8;
124124

125125
DROP TABLE DirectReports;
126126

127-
-- TODO(LFC): Seems creating distributed table has some column schema related issues, look into "order_variable_size_payload" test cases.
127+
-- TODO(LFC): Seems creating distributed table has some column schema related issues, look into "order_variable_size_payload" test case.

0 commit comments

Comments
 (0)