chore: minor fix

Author: fengjiachun

src/datanode/src/sql/copy_table.rs

@@ -24,8 +24,8 @@ use datafusion::physical_plan::RecordBatchStream;
 use futures::TryStreamExt;
 use object_store::services::fs::Builder;
 use object_store::ObjectStore;
-use snafu::ResultExt;
-use table::engine::TableReference;
+use snafu::{OptionExt, ResultExt};
+use table::engine::{EngineContext, TableReference};
 use table::requests::CopyTableRequest;
 
 use crate::error::{self, Result};
@@ -39,7 +39,15 @@ impl SqlHandler {
             table: &req.table_name.to_string(),
         };
 
-        let table = self.get_table(&table_ref)?;
+        let table = self
+            .table_engine()
+            .get_table(&EngineContext::default(), &table_ref)
+            .context(error::GetTableSnafu {
+                table_name: table_ref.to_string(),
+            })?
+            .context(error::TableNotFoundSnafu {
+                table_name: table_ref.to_string(),
+            })?;
 
         let stream = table
             .scan(None, &[], None)
@@ -48,14 +56,12 @@ impl SqlHandler {
                 table_name: table_ref.to_string(),
             })?;
 
-        let session_ctx = SessionContext::new();
         let stream = stream
-            .execute(0, session_ctx.task_ctx())
+            .execute(0, SessionContext::default().task_ctx())
             .context(error::TableScanExecSnafu)?;
         let stream = Box::pin(DfRecordBatchStreamAdapter::new(stream));
 
-        // TODO(jiachun): make this configurable
-        let accessor = Builder::default().root(".").build().unwrap();
+        let accessor = Builder::default().build().unwrap();
         let object_store = ObjectStore::new(accessor);
 
         let mut parquet_writer = ParquetWriter::new(req.file_name, stream, object_store);
@@ -84,7 +90,7 @@ impl ParquetWriter {
             object_store,
             // TODO(jiachun): make these configurable
             max_row_group_size: 4096,
-            max_rows_in_segment: 100000,
+            max_rows_in_segment: 1000000,
         }
     }
 

src/frontend/src/instance.rs

@@ -576,6 +576,9 @@ pub fn check_permission(
         Statement::DescribeTable(stmt) => {
             validate_param(stmt.name(), query_ctx)?;
         }
+        Statement::Copy(stmd) => {
+            validate_param(stmd.table_name(), query_ctx)?;
+        }
     }
     Ok(())
 }

src/sql/src/parsers/copy_parser.rs

@@ -1,3 +1,17 @@
+// Copyright 2023 Greptime Team
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
 use snafu::ResultExt;
 use sqlparser::keywords::Keyword;
 

src/sql/src/statements/copy.rs

@@ -1,3 +1,17 @@
+// Copyright 2023 Greptime Team
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
 use sqlparser::ast::ObjectName;
 
 #[derive(Debug, Clone, PartialEq, Eq)]