Skip to content

Commit 4d66d9e

Browse files
committed
feat/auto-schema-align:
Add TODO comments for future improvements in `pending_rows_batcher.rs` - Added a TODO comment to consider bounding the `flush_region_writes_concurrently` function. - Added a TODO comment to potentially limit the maximum rows to concatenate in the `flush_batch_physical` function. Signed-off-by: Lei, HUANG <mrsatangel@gmail.com>
1 parent 7cb69d9 commit 4d66d9e

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

src/servers/src/pending_rows_batcher.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -972,6 +972,7 @@ async fn flush_region_writes_concurrently(
972972
}
973973
});
974974

975+
// todo(hl): should be bounded.
975976
futures::future::join_all(write_futures).await
976977
}
977978

@@ -1240,6 +1241,7 @@ async fn flush_batch_physical(
12401241
.with_label_values(&["flush_physical_concat_all"])
12411242
.start_timer();
12421243
let combined_schema = modified_batches[0].schema();
1244+
// todo(hl): maybe limit max rows to concat.
12431245
match concat_batches(&combined_schema, &modified_batches) {
12441246
Ok(batch) => batch,
12451247
Err(err) => {

0 commit comments

Comments
 (0)