fix: format -> join_dir

Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>

Author: zhongzc

src/mito2/src/cache/write_cache.rs

@@ -222,6 +222,7 @@ mod tests {
     use common_test_util::temp_dir::create_temp_dir;
     use object_store::manager::ObjectStoreManager;
     use object_store::services::Fs;
+    use object_store::util::join_path;
     use object_store::ObjectStore;
     use store_api::storage::RegionId;
 
@@ -245,7 +246,7 @@ mod tests {
         let file_id = FileId::random();
         let upload_path = sst_file_path("test", file_id);
         let index_upload_path = index_file_path("test", file_id);
-        let intm_mgr = IntermediateManager::init_fs(format!("{data_home}/intermediate"))
+        let intm_mgr = IntermediateManager::init_fs(join_path(&data_home, "intm"))
             .await
             .unwrap();
 

src/mito2/src/sst/file_purger.rs

@@ -97,6 +97,7 @@ impl FilePurger for LocalFilePurger {
 mod tests {
     use common_test_util::temp_dir::create_temp_dir;
     use object_store::services::Fs;
+    use object_store::util::join_path;
     use object_store::ObjectStore;
     use smallvec::SmallVec;
 
@@ -118,7 +119,7 @@ mod tests {
         let sst_file_id = FileId::random();
         let sst_dir = "table1";
         let path = location::sst_file_path(sst_dir, sst_file_id);
-        let intm_mgr = IntermediateManager::init_fs(format!("{dir_path}/intm"))
+        let intm_mgr = IntermediateManager::init_fs(join_path(&dir_path, "intm"))
             .await
             .unwrap();
 
@@ -162,7 +163,7 @@ mod tests {
         builder.root(&dir_path);
         let sst_file_id = FileId::random();
         let sst_dir = "table1";
-        let intm_mgr = IntermediateManager::init_fs(format!("{dir_path}/intm"))
+        let intm_mgr = IntermediateManager::init_fs(join_path(&dir_path, "intm"))
             .await
             .unwrap();
         let path = location::sst_file_path(sst_dir, sst_file_id);

src/mito2/src/sst/index/creator.rs

@@ -125,7 +125,7 @@ impl SstIndexCreator {
         if let Err(update_err) = self.do_update(batch).await {
             // clean up garbage if failed to update
             if let Err(err) = self.do_cleanup().await {
-                warn!(err; "Failed to clean up index creator");
+                warn!(err; "Failed to clean up index creator, file_path: {}", self.file_path);
             }
             return Err(update_err);
         }
@@ -146,7 +146,7 @@ impl SstIndexCreator {
         let finish_res = self.do_finish().await;
         // clean up garbage no matter finish successfully or not
         if let Err(err) = self.do_cleanup().await {
-            warn!(err; "Failed to clean up index creator");
+            warn!(err; "Failed to clean up index creator, file_path: {}", self.file_path);
         }
 
         finish_res.map(|_| (self.stats.row_count(), self.stats.byte_count()))

src/mito2/src/test_util/scheduler_util.rs

@@ -18,6 +18,7 @@ use std::sync::Arc;
 
 use common_test_util::temp_dir::{create_temp_dir, TempDir};
 use object_store::services::Fs;
+use object_store::util::join_dir;
 use object_store::ObjectStore;
 use tokio::sync::mpsc::Sender;
 
@@ -46,7 +47,7 @@ impl SchedulerEnv {
         let mut builder = Fs::default();
         builder.root(&path_str);
 
-        let intm_mgr = IntermediateManager::init_fs(join_dir(path_str, "interm"))
+        let intm_mgr = IntermediateManager::init_fs(join_dir(&path_str, "intm"))
             .await
             .unwrap();
         let object_store = ObjectStore::new(builder).unwrap().finish();