Skip to content

Commit cdf190d

Browse files
authored
Merge pull request #63 from TwiterZX/make_shield_service_dynamic
Make shield service dynamic
2 parents e2f8f52 + 381b353 commit cdf190d

File tree

3 files changed

+21
-17
lines changed

3 files changed

+21
-17
lines changed

lib/badge/base.rb

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,19 +27,23 @@ def self.alpha_dark_badge
2727
File.join assets, 'alpha_badge_dark.png'
2828
end
2929

30-
def self.shield_base_url
30+
def self.shield_service_name
31+
'shields.io'
32+
end
33+
34+
def self.shield_serveice_base_url
3135
'https://img.shields.io'
3236
end
3337

3438
def self.shield_path
3539
'/badge/'
3640
end
3741

38-
def self.shield_io_timeout
42+
def self.shield_service_timeout
3943
10
4044
end
4145

42-
def self.shield_io_retries
46+
def self.shield_service_retries
4347
10
4448
end
4549

lib/badge/options.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,11 +33,11 @@ def self.available_options
3333
optional: true),
3434

3535
FastlaneCore::ConfigItem.new(key: :shield,
36-
description: "Overlay a shield from shields.io on your icon, eg: Version-1.2-green",
36+
description: "Overlay a shield from #{Badge.shield_service_name} on your icon, eg: Version-1.2-green",
3737
optional: true),
3838

39-
FastlaneCore::ConfigItem.new(key: :shield_io_timeout,
40-
description: "The timeout in seconds we should wait the get a response from shields.io",
39+
FastlaneCore::ConfigItem.new(key: :shield_service_timeout,
40+
description: "The timeout in seconds we should wait the get a response from #{Badge.shield_service_name}",
4141
type: Integer,
4242
optional: true),
4343

lib/badge/runner.rb

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -27,29 +27,29 @@ def run(path, options)
2727

2828
shield = nil
2929
begin
30-
timeout = Badge.shield_io_timeout
31-
timeout = options[:shield_io_timeout] if options[:shield_io_timeout]
30+
timeout = Badge.shield_service_timeout
31+
timeout = options[:shield_service_timeout] if options[:shield_service_timeout]
3232
Timeout.timeout(timeout.to_i) do
3333
shield = load_shield(options[:shield]) if options[:shield]
3434
end
3535
rescue Timeout::Error
36-
UI.error "Error loading image from shields.io timeout reached. Use --verbose for more info".red
36+
UI.error "Error loading image from #{Badge.shield_service_name} timeout reached. Use --verbose for more info".red
3737
rescue Curl::Err::CurlError => error
3838
response = error.io
39-
UI.error "Error loading image from shields.io response Error. Use --verbose for more info".red
39+
UI.error "Error loading image from #{Badge.shield_service_name} response Error. Use --verbose for more info".red
4040
UI.verbose response.status if FastlaneCore::Globals.verbose?
4141
rescue MiniMagick::Invalid
42-
UI.error "Error validating image from shields.io. Use --verbose for more info".red
42+
UI.error "Error validating image from #{Badge.shield_service_name}. Use --verbose for more info".red
4343
rescue Exception => error
4444
UI.error "Other error occured. Use --verbose for more info".red
4545
UI.verbose error if FastlaneCore::Globals.verbose?
4646
end
4747

4848
if options[:shield] && shield == nil
49-
if @@retry_attemps >= Badge.shield_io_retries
50-
UI.error "Cannot load image from shields.io skipping it...".red
49+
if @@retry_attemps >= Badge.shield_service_retries
50+
UI.error "Cannot load image from #{Badge.shield_service_name} skipping it...".red
5151
else
52-
UI.message "Waiting for #{timeout.to_i}s and retry to load image from shields.io tries remaining: #{Badge.shield_io_retries - @@retry_attemps}".red
52+
UI.message "Waiting for #{timeout.to_i}s and retry to load image from #{Badge.shield_service_name} tries remaining: #{Badge.shield_service_retries - @@retry_attemps}".red
5353
sleep timeout.to_i
5454
@@retry_attemps += 1
5555
return run(path, options)
@@ -95,7 +95,7 @@ def run(path, options)
9595

9696
def add_shield(icon, result, shield, alpha_channel, shield_gravity, shield_no_resize, shield_scale, shield_geometry)
9797
UI.message "'#{icon.path}'"
98-
UI.verbose "Adding shields.io image ontop of icon".blue
98+
UI.verbose "Adding #{Badge.shield_service_name} image ontop of icon".blue
9999

100100
shield_scale = shield_scale ? shield_scale.to_f : 1.0
101101

@@ -120,10 +120,10 @@ def add_shield(icon, result, shield, alpha_channel, shield_gravity, shield_no_re
120120
end
121121

122122
def load_shield(shield_string)
123-
url = Badge.shield_base_url + Badge.shield_path + shield_string + (@@rsvg_enabled ? ".svg" : ".png")
123+
url = Badge.shield_serveice_base_url + Badge.shield_path + shield_string + (@@rsvg_enabled ? ".svg" : ".png")
124124
file_name = shield_string + (@@rsvg_enabled ? ".svg" : ".png")
125125

126-
UI.verbose "Trying to load image from shields.io. Timeout: #{Badge.shield_io_timeout}s".blue
126+
UI.verbose "Trying to load image from #{Badge.shield_service_name}. Timeout: #{Badge.shield_service_timeout}s".blue
127127
UI.verbose "URL: #{url}".blue
128128

129129
Curl::Easy.download(url, file_name)

0 commit comments

Comments
 (0)