Merge pull request #2266 from dastgirp/coverity/fix2

MishimaHaruna · web-flow · commit 776befcb4eed · 2020-01-13T00:03:35.000+01:00
Fixed a condition in RoDEX attachment
diff --git a/src/map/clif.c b/src/map/clif.c
@@ -16891,7 +16891,7 @@ static void clif_parse_Mail_getattach(int fd, struct map_session_data *sd)
 	if( sd->mail.inbox.msg[i].zeny < 1 && (sd->mail.inbox.msg[i].item.nameid < 1 || sd->mail.inbox.msg[i].item.amount < 1) )
 		return;
 
-	if( sd->mail.inbox.msg[i].zeny + sd->status.zeny > MAX_ZENY ) {
+	if( sd->mail.inbox.msg[i].zeny > MAX_ZENY - sd->status.zeny ) {
 		clif->mail_getattachment(fd, 1);
 		return;
 	}

Original file line number	Diff line number	Diff line change
`@@ -16891,7 +16891,7 @@ static void clif_parse_Mail_getattach(int fd, struct map_session_data *sd)`
`16891`	`16891`	`if( sd->mail.inbox.msg[i].zeny < 1 && (sd->mail.inbox.msg[i].item.nameid < 1 \|\| sd->mail.inbox.msg[i].item.amount < 1) )`
`16892`	`16892`	`return;`
`16893`	`16893`
`16894`		`- if( sd->mail.inbox.msg[i].zeny + sd->status.zeny > MAX_ZENY ) {`
	`16894`	`+ if( sd->mail.inbox.msg[i].zeny > MAX_ZENY - sd->status.zeny ) {`
`16895`	`16895`	`clif->mail_getattachment(fd, 1);`
`16896`	`16896`	`return;`
`16897`	`16897`	`}`