folly: fix build on 10.12 and 10.11 with Xcode 8 #5548
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Since the fix landed facebook/folly@a34e06a This workaround is now breaking "brew install --HEAD folly" |
|
@yschimke perhaps you can encourage them to put out a new release :) |
|
I think there is a new release, is that what you need? https://github.com/facebook/folly/releases |
|
@yschimke yup thanks for the heads up! |
|
@yschimke unfortunately it looks like while it's fixed for 10.12, it still fails to build on 10.11 + Xcode 8 :( |
ilovezfs
added
clock_gettime
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cf. facebook/folly#488.