Fix exception shown during Telemetry

HowardWolosky · HowardWolosky · commit 95b45bd8f55b · 2020-08-24T07:09:03.000-07:00
When microsoft#201 brought over the raw telemetry work from PowerShellForGitHub, it erroneously left in a `Get-GitHubConfiguration` call which should have been removed.
diff --git a/StoreBroker/Telemetry.ps1 b/StoreBroker/Telemetry.ps1
@@ -184,10 +184,7 @@ function Get-BaseTelemetryEvent
 
     if ($null -eq $script:SBBaseTelemetryEvent)
     {
-        if (-not (Get-GitHubConfiguration -Name SuppressTelemetryReminder))
-        {
-            Write-Log -Message "Telemetry is currently enabled.  It can be disabled by setting ""`$global:SBDisableTelemetry = `$true"". Refer to USAGE.md#telemetry for more information."
-        }
+        Write-Log -Message "Telemetry is currently enabled.  It can be disabled by setting ""`$global:SBDisableTelemetry = `$true"". Refer to USAGE.md#telemetry for more information."
 
         $username = Get-PiiSafeString -PlainText $env:USERNAME
 

Original file line number	Diff line number	Diff line change
`@@ -184,10 +184,7 @@ function Get-BaseTelemetryEvent`
`184`	`184`
`185`	`185`	`if ($null -eq $script:SBBaseTelemetryEvent)`
`186`	`186`	`{`
`187`		`- if (-not (Get-GitHubConfiguration -Name SuppressTelemetryReminder))`
`188`		`- {`
`189`		- Write-Log -Message "Telemetry is currently enabled. It can be disabled by setting ""`$global:SBDisableTelemetry = `$true"". Refer to USAGE.md#telemetry for more information."
`190`		`- }`
	`187`	+ Write-Log -Message "Telemetry is currently enabled. It can be disabled by setting ""`$global:SBDisableTelemetry = `$true"". Refer to USAGE.md#telemetry for more information."
`191`	`188`
`192`	`189`	`$username = Get-PiiSafeString -PlainText $env:USERNAME`
`193`	`190`