ci: try fix warns on master

Author: kRHYME7

.github/workflows/warn-master-pr.yml

@@ -29,49 +29,68 @@ jobs:
             }
             
             // Check if this is a PR from a fork (external contributor)
-            const isFromFork = context.payload.pull_request.head.repo.full_name !== context.payload.pull_request.base.repo.full_name;
+            const headRepo = context.payload.pull_request.head.repo?.full_name;
+            const baseRepo = context.payload.pull_request.base.repo.full_name;
+            const isFromFork = headRepo && headRepo !== baseRepo;
+            
+            console.log(`PR Details: Head repo: ${headRepo}, Base repo: ${baseRepo}, Is fork: ${isFromFork}`);
             
             if (isFromFork) {
               console.log('PR is from a fork (external contributor)');
-              // For fork PRs, we can only create PR reviews, not issue comments
+              // For fork PRs, try comment first, then review as fallback
               try {
-                // Check if we already have a review
-                const reviews = await github.rest.pulls.listReviews({
+                // Check if we already commented
+                const comments = await github.rest.issues.listComments({
                   owner,
                   repo,
-                  pull_number: issue_number
+                  issue_number
                 });
                 
-                const botReview = reviews.data.find(review => 
-                  review.user.login === 'github-actions[bot]' && 
-                  review.body && review.body.includes('⚠️ Warning: PR targeting master branch')
+                const botComment = comments.data.find(comment => 
+                  comment.user.login === 'github-actions[bot]' && 
+                  comment.body.includes('⚠️ Warning: PR targeting master branch')
                 );
                 
-                if (!botReview) {
-                  await github.rest.pulls.createReview({
+                if (!botComment) {
+                  await github.rest.issues.createComment({
                     owner,
                     repo,
-                    pull_number: issue_number,
-                    event: 'REQUEST_CHANGES',
-                    body: "⚠️ **Warning: PR targeting master branch detected!**\n\n**This PR is targeting `master` but should target `dev` instead.**\n\nAccording to our [CONTRIBUTING.md](https://github.com/HyDE-Project/HyDE/blob/master/CONTRIBUTING.md) and [RELEASE_POLICY.md](https://github.com/HyDE-Project/HyDE/blob/master/RELEASE_POLICY.md):\n\n- **All pull requests must be submitted to the `dev` branch**\n- Changes go through `dev` first for testing before being merged to `master` during release windows\n- **PRs to `master` are only allowed for emergencies**\n\n**Required Action:**\n1. **Change the base branch from `master` to `dev`**\n2. Follow the [pull request template](https://github.com/HyDE-Project/HyDE/blob/master/.github/PULL_REQUEST_TEMPLATE.md)\n\n**If this is an emergency fix, please add a comment explaining why it needs to target `master` directly.**\n\n---\n*This is an automated review enforcing our contribution workflow.*"
+                    issue_number,
+                    body: "⚠️ **Warning: PR targeting master branch detected!** Please change the base branch to `dev` instead of `master`. See our [CONTRIBUTING.md](https://github.com/HyDE-Project/HyDE/blob/master/CONTRIBUTING.md) for details."
                   });
-                  console.log('Warning review added to fork PR #' + issue_number);
+                  console.log('Comment added to fork PR #' + issue_number);
                 } else {
-                  console.log('Warning review already exists for fork PR #' + issue_number);
+                  console.log('Comment already exists for fork PR #' + issue_number);
                 }
               } catch (error) {
-                console.log('Failed to create review for fork PR:', error.message);
-                // Fallback: try to add a regular comment anyway
+                console.log('Failed to create comment for fork PR, trying review:', error.message);
+                // Fallback: try to add a review
                 try {
-                  await github.rest.issues.createComment({
+                  const reviews = await github.rest.pulls.listReviews({
                     owner,
                     repo,
-                    issue_number,
-                    body: "⚠️ **Warning: PR targeting master branch detected!** Please change the base branch to `dev` instead of `master`. See our [CONTRIBUTING.md](https://github.com/HyDE-Project/HyDE/blob/master/CONTRIBUTING.md) for details."
+                    pull_number: issue_number
                   });
-                  console.log('Fallback comment added to fork PR #' + issue_number);
-                } catch (fallbackError) {
-                  console.log('Both review and comment failed for fork PR:', fallbackError.message);
+                  
+                  const botReview = reviews.data.find(review => 
+                    review.user.login === 'github-actions[bot]' && 
+                    review.body && review.body.includes('⚠️ Warning: PR targeting master branch')
+                  );
+                  
+                  if (!botReview) {
+                    await github.rest.pulls.createReview({
+                      owner,
+                      repo,
+                      pull_number: issue_number,
+                      event: 'COMMENT',
+                      body: "⚠️ **Warning: PR targeting master branch detected!** Please change the base branch to `dev` instead of `master`. See our [CONTRIBUTING.md](https://github.com/HyDE-Project/HyDE/blob/master/CONTRIBUTING.md) for details."
+                    });
+                    console.log('Review added to fork PR #' + issue_number);
+                  } else {
+                    console.log('Review already exists for fork PR #' + issue_number);
+                  }
+                } catch (reviewError) {
+                  console.log('Both comment and review failed for fork PR:', reviewError.message);
                 }
               }
             } else {