Skip to content

Commit 9831c86

Browse files
wnm3claude
andcommitted
Document Maven build-warning cleanup in migration design doc (#430)
Record the pom.xml build-warning fixes (bnd private-reference exports, invalid maven-compiler-plugin/maven-assembly-plugin parameters) and note that the gpg.passphrase deprecation originates from local settings.xml, not the project pom. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
1 parent e35d2b9 commit 9831c86

1 file changed

Lines changed: 21 additions & 0 deletions

File tree

docs/specs/Jackson-3-Migration-Design.md

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -125,6 +125,27 @@ becomes unreachable, or the type is no longer resolvable, replace with
125125
- **JPMS.** No `module-info.java` exists; no module changes required.
126126
- No other plugin configuration references Jackson.
127127

128+
### Maven build-warning cleanup (unrelated to Jackson, done on this branch)
129+
130+
While migrating, three pre-existing Maven warnings surfaced on every build and were fixed in
131+
`pom.xml`:
132+
133+
- **bnd private-reference warnings (×2).** The exported `com.api.jsonata4java` and
134+
`com.api.jsonata4java.expressions` packages expose types from
135+
`com.api.jsonata4java.expressions.regex` (`RegexEngine`, `RegexPattern`, …) in their public API,
136+
but that sub-package was not in the `Export-Package` list, so bnd flagged it as a leaked private
137+
reference. Added `com.api.jsonata4java.expressions.regex` to `Export-Package`.
138+
- **`additionalClasspathElements` unknown (×2).** Removed the empty
139+
`<additionalClasspathElements/>` from `maven-compiler-plugin` — not a valid parameter for that
140+
plugin (it did nothing).
141+
- **`excludes` unknown on assembly plugin.** Removed `<excludes>` from the `maven-assembly-plugin`
142+
`single` goal — not a valid parameter there (exclusions belong in an assembly descriptor); it was
143+
silently ignored and does not affect the produced `jar-with-dependencies`.
144+
145+
A fourth warning — `gpg.passphrase` deprecated — originates from the developer's
146+
`~/.m2/settings.xml` (an `activeByDefault` profile setting the deprecated property), **not** from
147+
`pom.xml`, and is resolved locally by removing that property and relying on `gpg-agent`.
148+
128149
## Out of scope
129150

130151
- Any behavioral changes beyond what the package/API migration requires.

0 commit comments

Comments
 (0)