Skip to content
This repository was archived by the owner on Jul 30, 2025. It is now read-only.

Conversation

@myan9
Copy link
Contributor

@myan9 myan9 commented Apr 6, 2020

Fixes #4205

Description of what you did:

My PR is a:

  • 💥 Breaking change
  • 🐛 Bug fix
  • 💅 Enhancement
  • 🚀 New feature

Please confirm that your PR fulfills these requirements

  • Multiple commits are squashed into one commit.
  • The commit message follows Conventional Commits, which allows us to autogenerate release notes; e.g. fix(plugins/plugin-k8s): fixed annoying bugs
  • All npm dependencies are pinned.

@myan9 myan9 requested a review from starpit as a code owner April 6, 2020 20:11
@codecov
Copy link

codecov bot commented Apr 6, 2020

Codecov Report

Merging #4208 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4208   +/-   ##
=======================================
  Coverage   59.31%   59.31%           
=======================================
  Files          74       74           
  Lines        2399     2399           
  Branches      582      582           
=======================================
  Hits         1423     1423           
  Misses        749      749           
  Partials      227      227           
Impacted Files Coverage Δ
packages/core/src/models/NavResponse.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b95cbdb...112dd2d. Read the comment docs.

Copy link
Contributor

@starpit starpit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the kustomize change doesn't look right. you changed resources.reduce into resources.map. but we want a single Menu for all Deployments (with one item per ...); with your change, there will be one Menu per Deployment, each with just a single item

@myan9
Copy link
Contributor Author

myan9 commented Apr 7, 2020

the kustomize change doesn't look right. you changed resources.reduce into resources.map. but we want a single Menu for all Deployments (with one item per ...); with your change, there will be one Menu per Deployment, each with just a single item

fixed, thanks!

Copy link
Contributor

@starpit starpit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@starpit starpit merged commit e849ae7 into kubernetes-retired:master Apr 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NavResponse can type check but not render properly

2 participants