Skip to content
This repository was archived by the owner on Jul 30, 2025. It is now read-only.

Conversation

@starpit
Copy link
Contributor

@starpit starpit commented Apr 8, 2020

…closed sidecar

Fixes #4218

Description of what you did:

My PR is a:

  • 💥 Breaking change
  • 🐛 Bug fix
  • 💅 Enhancement
  • 🚀 New feature

Please confirm that your PR fulfills these requirements

  • Multiple commits are squashed into one commit.
  • The commit message follows Conventional Commits, which allows us to autogenerate release notes; e.g. fix(plugins/plugin-k8s): fixed annoying bugs
  • All npm dependencies are pinned.

@codecov
Copy link

codecov bot commented Apr 8, 2020

Codecov Report

Merging #4219 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4219   +/-   ##
=======================================
  Coverage   59.31%   59.31%           
=======================================
  Files          74       74           
  Lines        2399     2399           
  Branches      582      582           
=======================================
  Hits         1423     1423           
  Misses        749      749           
  Partials      227      227           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e849ae7...6ea1554. Read the comment docs.

@starpit starpit merged commit bfa96ed into kubernetes-retired:master Apr 8, 2020
@starpit starpit deleted the fix-4218 branch April 8, 2020 22:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

escape key toggles sidecar open (to blank) when it is otherwise fully closed

1 participant