Skip to content
This repository was archived by the owner on Jul 30, 2025. It is now read-only.

Conversation

@starpit
Copy link
Contributor

@starpit starpit commented Apr 9, 2020

this PR also uses this for the READY column in kubectl tables

Fixes #4232

Description of what you did:

My PR is a:

  • 💥 Breaking change
  • 🐛 Bug fix
  • 💅 Enhancement
  • 🚀 New feature

Please confirm that your PR fulfills these requirements

  • Multiple commits are squashed into one commit.
  • The commit message follows Conventional Commits, which allows us to autogenerate release notes; e.g. fix(plugins/plugin-k8s): fixed annoying bugs
  • All npm dependencies are pinned.

this PR also uses this for the READY column in kubectl tables

Fixes kubernetes-retired#4232
@codecov
Copy link

codecov bot commented Apr 10, 2020

Codecov Report

Merging #4245 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4245   +/-   ##
=======================================
  Coverage   59.27%   59.27%           
=======================================
  Files          74       74           
  Lines        2399     2399           
  Branches      582      582           
=======================================
  Hits         1422     1422           
  Misses        750      750           
  Partials      227      227           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80caabd...6cf0e6a. Read the comment docs.

@starpit starpit merged commit 7d2a7e0 into kubernetes-retired:master Apr 10, 2020
@starpit starpit deleted the fix-4232 branch April 10, 2020 00:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

terminal table columns should auto-hide based on font-zoom?

1 participant