Skip to content
This repository was archived by the owner on Jul 30, 2025. It is now read-only.

Conversation

@starpit
Copy link
Contributor

@starpit starpit commented Apr 10, 2020

Fixes #4246

Description of what you did:

My PR is a:

  • 💥 Breaking change
  • 🐛 Bug fix
  • 💅 Enhancement
  • 🚀 New feature

Please confirm that your PR fulfills these requirements

  • Multiple commits are squashed into one commit.
  • The commit message follows Conventional Commits, which allows us to autogenerate release notes; e.g. fix(plugins/plugin-k8s): fixed annoying bugs
  • All npm dependencies are pinned.

@codecov
Copy link

codecov bot commented Apr 10, 2020

Codecov Report

Merging #4247 into master will decrease coverage by 0.20%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4247      +/-   ##
==========================================
- Coverage   59.48%   59.27%   -0.21%     
==========================================
  Files          74       74              
  Lines        2399     2399              
  Branches      582      582              
==========================================
- Hits         1427     1422       -5     
- Misses        745      750       +5     
  Partials      227      227              
Impacted Files Coverage Δ
packages/core/src/util/i18n.ts 56.00% <0.00%> (-8.00%) ⬇️
packages/core/src/core/userdata.ts 63.88% <0.00%> (-4.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d2a7e0...c89fe0d. Read the comment docs.

@starpit starpit merged commit af894d6 into kubernetes-retired:master Apr 10, 2020
@starpit starpit deleted the fix-4246 branch April 10, 2020 13:17
myan9 added a commit to myan9/kui that referenced this pull request Apr 10, 2020
myan9 added a commit to myan9/kui that referenced this pull request Apr 10, 2020
myan9 added a commit to myan9/kui that referenced this pull request Apr 10, 2020
myan9 added a commit to myan9/kui that referenced this pull request Apr 10, 2020
myan9 added a commit to myan9/kui that referenced this pull request Apr 10, 2020
myan9 added a commit to myan9/kui that referenced this pull request Apr 10, 2020
starpit pushed a commit that referenced this pull request Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

electron windows build issue

1 participant