Skip to content
This repository was archived by the owner on Jul 30, 2025. It is now read-only.

Conversation

@starpit
Copy link
Contributor

@starpit starpit commented Apr 10, 2020

  1. use normal font size
  2. opacity for context
  3. for carbon themes, use plex sans condensed for context

Fixes #4250

Description of what you did:

My PR is a:

  • 💥 Breaking change
  • 🐛 Bug fix
  • 💅 Enhancement
  • 🚀 New feature

Please confirm that your PR fulfills these requirements

  • Multiple commits are squashed into one commit.
  • The commit message follows Conventional Commits, which allows us to autogenerate release notes; e.g. fix(plugins/plugin-k8s): fixed annoying bugs
  • All npm dependencies are pinned.

1) use normal font size
2) opacity for context
3) for carbon themes, use plex sans condensed for context

Fixes kubernetes-retired#4250
@codecov
Copy link

codecov bot commented Apr 10, 2020

Codecov Report

Merging #4251 into master will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4251      +/-   ##
==========================================
+ Coverage   59.27%   59.35%   +0.08%     
==========================================
  Files          74       74              
  Lines        2399     2399              
  Branches      582      582              
==========================================
+ Hits         1422     1424       +2     
+ Misses        750      748       -2     
  Partials      227      227              
Impacted Files Coverage Δ
packages/core/src/util/i18n.ts 64.00% <0.00%> (+8.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af894d6...903917b. Read the comment docs.

@starpit starpit merged commit 7bf658a into kubernetes-retired:master Apr 10, 2020
@starpit starpit deleted the fix-4250 branch April 10, 2020 17:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

a few more tweaks to prompt

1 participant